* [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe
@ 2013-01-25 19:49 David Goulet
2013-01-25 19:51 ` David Goulet
2013-01-25 20:01 ` Mathieu Desnoyers
0 siblings, 2 replies; 3+ messages in thread
From: David Goulet @ 2013-01-25 19:49 UTC (permalink / raw)
From: David Goulet <dgoulet@efficios.com>
Signed-off-by: David Goulet <dgoulet at efficios.com>
---
instrumentation/events/lttng-module/btrfs.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/instrumentation/events/lttng-module/btrfs.h b/instrumentation/events/lttng-module/btrfs.h
index c01a6e0..34ae480 100644
--- a/instrumentation/events/lttng-module/btrfs.h
+++ b/instrumentation/events/lttng-module/btrfs.h
@@ -390,7 +390,7 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
#endif
)
-DEFINE_EVENT(btrfs__writepage, __extent_writepage,
+DEFINE_EVENT(btrfs__writepage, btrfs_extent_writepage,
TP_PROTO(struct page *page, struct inode *inode,
struct writeback_control *wbc),
@@ -792,7 +792,7 @@ DEFINE_EVENT(btrfs__reserved_extent, btrfs_reserved_extent_free,
)
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,3,0))
-TRACE_EVENT(find_free_extent,
+TRACE_EVENT(btrfs_find_free_extent,
TP_PROTO(struct btrfs_root *root, u64 num_bytes, u64 empty_size,
u64 data),
@@ -956,7 +956,7 @@ TRACE_EVENT(btrfs_setup_cluster,
#endif
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,4,0))
-TRACE_EVENT(alloc_extent_state,
+TRACE_EVENT(btrfs_alloc_extent_state,
TP_PROTO(struct extent_state *state, gfp_t mask, unsigned long IP),
@@ -978,7 +978,7 @@ TRACE_EVENT(alloc_extent_state,
show_gfp_flags(__entry->mask), (void *)__entry->ip)
)
-TRACE_EVENT(free_extent_state,
+TRACE_EVENT(btrfs_free_extent_state,
TP_PROTO(struct extent_state *state, unsigned long IP),
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe
2013-01-25 19:49 [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe David Goulet
@ 2013-01-25 19:51 ` David Goulet
2013-01-25 20:01 ` Mathieu Desnoyers
1 sibling, 0 replies; 3+ messages in thread
From: David Goulet @ 2013-01-25 19:51 UTC (permalink / raw)
Meh... A file is missing in this patch.
Ignore, resending soon!
David Goulet:
> From: David Goulet <dgoulet@efficios.com>
>
> Signed-off-by: David Goulet <dgoulet at efficios.com>
> ---
> instrumentation/events/lttng-module/btrfs.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/instrumentation/events/lttng-module/btrfs.h b/instrumentation/events/lttng-module/btrfs.h
> index c01a6e0..34ae480 100644
> --- a/instrumentation/events/lttng-module/btrfs.h
> +++ b/instrumentation/events/lttng-module/btrfs.h
> @@ -390,7 +390,7 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
> #endif
> )
>
> -DEFINE_EVENT(btrfs__writepage, __extent_writepage,
> +DEFINE_EVENT(btrfs__writepage, btrfs_extent_writepage,
>
> TP_PROTO(struct page *page, struct inode *inode,
> struct writeback_control *wbc),
> @@ -792,7 +792,7 @@ DEFINE_EVENT(btrfs__reserved_extent, btrfs_reserved_extent_free,
> )
>
> #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,3,0))
> -TRACE_EVENT(find_free_extent,
> +TRACE_EVENT(btrfs_find_free_extent,
>
> TP_PROTO(struct btrfs_root *root, u64 num_bytes, u64 empty_size,
> u64 data),
> @@ -956,7 +956,7 @@ TRACE_EVENT(btrfs_setup_cluster,
> #endif
>
> #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,4,0))
> -TRACE_EVENT(alloc_extent_state,
> +TRACE_EVENT(btrfs_alloc_extent_state,
>
> TP_PROTO(struct extent_state *state, gfp_t mask, unsigned long IP),
>
> @@ -978,7 +978,7 @@ TRACE_EVENT(alloc_extent_state,
> show_gfp_flags(__entry->mask), (void *)__entry->ip)
> )
>
> -TRACE_EVENT(free_extent_state,
> +TRACE_EVENT(btrfs_free_extent_state,
>
> TP_PROTO(struct extent_state *state, unsigned long IP),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe
2013-01-25 19:49 [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe David Goulet
2013-01-25 19:51 ` David Goulet
@ 2013-01-25 20:01 ` Mathieu Desnoyers
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2013-01-25 20:01 UTC (permalink / raw)
* David Goulet (dgoulet at ev0ke.net) wrote:
> From: David Goulet <dgoulet@efficios.com>
Nope, those prefix are missing upstream. I cannot take them until Linux
upstream is fixed. You might want to submit a patch on LKML, ccing those
responsible for:
commit 3f7de037fb3727b20bc27332cdcf2488b702394c
Author: Josef Bacik <josef at redhat.com>
Date: Thu Nov 10 08:29:20 2011 -0500
Btrfs: add allocator tracepoints
I used these tracepoints when figuring out what the cluster stuff was doing, so
add them to mainline in case we need to profile this stuff again. Thanks,
Signed-off-by: Josef Bacik <josef at redhat.com>
And the btrfs maintainer (found in MAINTAINERS).
Thanks,
Mathieu
>
> Signed-off-by: David Goulet <dgoulet at efficios.com>
> ---
> instrumentation/events/lttng-module/btrfs.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/instrumentation/events/lttng-module/btrfs.h b/instrumentation/events/lttng-module/btrfs.h
> index c01a6e0..34ae480 100644
> --- a/instrumentation/events/lttng-module/btrfs.h
> +++ b/instrumentation/events/lttng-module/btrfs.h
> @@ -390,7 +390,7 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
> #endif
> )
>
> -DEFINE_EVENT(btrfs__writepage, __extent_writepage,
> +DEFINE_EVENT(btrfs__writepage, btrfs_extent_writepage,
>
> TP_PROTO(struct page *page, struct inode *inode,
> struct writeback_control *wbc),
> @@ -792,7 +792,7 @@ DEFINE_EVENT(btrfs__reserved_extent, btrfs_reserved_extent_free,
> )
>
> #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,3,0))
> -TRACE_EVENT(find_free_extent,
> +TRACE_EVENT(btrfs_find_free_extent,
>
> TP_PROTO(struct btrfs_root *root, u64 num_bytes, u64 empty_size,
> u64 data),
> @@ -956,7 +956,7 @@ TRACE_EVENT(btrfs_setup_cluster,
> #endif
>
> #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,4,0))
> -TRACE_EVENT(alloc_extent_state,
> +TRACE_EVENT(btrfs_alloc_extent_state,
>
> TP_PROTO(struct extent_state *state, gfp_t mask, unsigned long IP),
>
> @@ -978,7 +978,7 @@ TRACE_EVENT(alloc_extent_state,
> show_gfp_flags(__entry->mask), (void *)__entry->ip)
> )
>
> -TRACE_EVENT(free_extent_state,
> +TRACE_EVENT(btrfs_free_extent_state,
>
> TP_PROTO(struct extent_state *state, unsigned long IP),
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-25 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-25 19:49 [lttng-dev] [PATCH lttng-modules] Fix: missing event's prefix in btrfs probe David Goulet
2013-01-25 19:51 ` David Goulet
2013-01-25 20:01 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox