[lttng-dev] [lttng-tools PATCH] Move metset in channel_set_attr after the null check

[mathieu.desnoyers@efficios.com (Mathieu Desnoyers)]

* Danny Serres (serres at live.ca) wrote:
> Signed-off-by: Danny Serres <serres at live.ca>

Hi Danny,

Your patch looks good ! Just one detail: I forgot to create a
efficios.com email for you. So I will create
"danny.serres at efficios.com", and you can sign-off your patch with this
email. It will be forwarded to your @live.ca email.

Thanks !

Mathieu

> ---
>  src/lib/lttng-ctl/lttng-ctl.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/lttng-ctl/lttng-ctl.c b/src/lib/lttng-ctl/lttng-ctl.c
> index 36069ef..356fb34 100644
> --- a/src/lib/lttng-ctl/lttng-ctl.c
> +++ b/src/lib/lttng-ctl/lttng-ctl.c
> @@ -885,13 +885,13 @@ int lttng_calibrate(struct lttng_handle *handle,
>  void lttng_channel_set_default_attr(struct lttng_domain *domain,
>  		struct lttng_channel_attr *attr)
>  {
> -	memset(attr, 0, sizeof(struct lttng_channel_attr));
> -
>  	/* Safety check */
>  	if (attr == NULL || domain == NULL) {
>  		return;
>  	}
>  
> +	memset(attr, 0, sizeof(struct lttng_channel_attr));
> +
>  	switch (domain->type) {
>  	case LTTNG_DOMAIN_KERNEL:
>  		attr->overwrite = DEFAULT_CHANNEL_OVERWRITE;
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com