From: serres@live.ca (Danny Serres)
Subject: [lttng-dev] [lttng-tools PATCH] Move metset in channel_set_attr after the null check
Date: Wed, 6 Jun 2012 14:54:30 -0400 [thread overview]
Message-ID: <1339008870-4891-1-git-send-email-serres@live.ca> (raw)
Signed-off-by: Danny Serres <serres at live.ca>
---
src/lib/lttng-ctl/lttng-ctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/lttng-ctl/lttng-ctl.c b/src/lib/lttng-ctl/lttng-ctl.c
index 36069ef..356fb34 100644
--- a/src/lib/lttng-ctl/lttng-ctl.c
+++ b/src/lib/lttng-ctl/lttng-ctl.c
@@ -885,13 +885,13 @@ int lttng_calibrate(struct lttng_handle *handle,
void lttng_channel_set_default_attr(struct lttng_domain *domain,
struct lttng_channel_attr *attr)
{
- memset(attr, 0, sizeof(struct lttng_channel_attr));
-
/* Safety check */
if (attr == NULL || domain == NULL) {
return;
}
+ memset(attr, 0, sizeof(struct lttng_channel_attr));
+
switch (domain->type) {
case LTTNG_DOMAIN_KERNEL:
attr->overwrite = DEFAULT_CHANNEL_OVERWRITE;
--
1.7.9.5
next reply other threads:[~2012-06-06 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 18:54 Danny Serres [this message]
2012-06-06 19:40 ` Mathieu Desnoyers
2012-06-07 17:05 ` David Goulet
2012-06-07 17:43 ` Yannick Brosseau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339008870-4891-1-git-send-email-serres@live.ca \
--to=serres@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox