Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [ltt-dev] [PATCH 6/7] rculfhash: Move key out of struct lfht_test_node
Date: Sat, 5 Nov 2011 09:42:53 -0400	[thread overview]
Message-ID: <20111105134253.GE15862@Krystal> (raw)
In-Reply-To: <14c55f6a4b1c3639c2fd1dfa31665b283ff17e5e.1320217693.git.laijs@cn.fujitsu.com>

* Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
> Make struct lfht_test_node only contains basic field.
> Let user take the responsibility to handle the <key>(hash_set)
> or <key,value>(hash_map) management and calculation.
> 
> Signed-off-by: Lai Jiangshan <laijs at cn.fujitsu.com>
[...]
> @@ -424,13 +427,18 @@ int __test_compare(void *key1, size_t key1_len,
>  static
>  int test_compare(struct cds_lfht_node *a, struct cds_lfht_node *b)
>  {
> -	return __test_compare(a->key, a->key_len, b->key, b->key_len);
> +	struct lfht_test_node *u = to_test_node(a);
> +	struct lfht_test_node *v = to_test_node(a);
> +
> +	return __test_compare(u->key, u->key_len, v->key, v->key_len);
>  }
>  

FYI, I think you had a tiny bug here (a -> b for the second). I've
replaced this patch with my own implementation, so it's not a problem.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com




  parent reply	other threads:[~2011-11-05 13:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02  7:50 [ltt-dev] [PATCH 0/7] rculfhash: More proper APIs and struct cds_lfht_node Lai Jiangshan
2011-11-02  7:50 ` [ltt-dev] [PATCH 1/7] rculfhash, test: wrap " Lai Jiangshan
2011-11-02 17:16   ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 2/7] rculfhash: Move "struct rcu_head head" out of "struct cds_lfht_node" Lai Jiangshan
2011-11-02 17:18   ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 3/7] rculfhash: make cds_lfht_lookup() more generic Lai Jiangshan
2011-11-02 17:23   ` Mathieu Desnoyers
2011-11-03 14:07     ` Lai Jiangshan
2011-11-04 10:08       ` Mathieu Desnoyers
2011-11-04 13:15         ` Lai Jiangshan
2011-11-04 13:53           ` Mathieu Desnoyers
2011-11-04 15:01             ` Lai Jiangshan
2011-11-05 13:08               ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 4/7] rculfhash: Comparision API use node pointer instead of key Lai Jiangshan
2011-11-05 13:10   ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 5/7] rculfhash: Pass hash value to cds_lfht_add* APIs Lai Jiangshan
2011-11-05 13:10   ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 6/7] rculfhash: Move key out of struct lfht_test_node Lai Jiangshan
2011-11-05 13:12   ` Mathieu Desnoyers
2011-11-05 13:42   ` Mathieu Desnoyers [this message]
2011-11-05 13:52   ` Mathieu Desnoyers
2011-11-02  7:50 ` [ltt-dev] [PATCH 7/7] rculfhash: cleanup struct _cds_lfht_node Lai Jiangshan
2011-11-04  7:47   ` [ltt-dev] [PATCH 1/2] rculfhash: rename dummy to bucket Lai Jiangshan
2011-11-04  7:47     ` [ltt-dev] [PATCH 2/2] rculfhash: simplify BUCKET_FLAG tracking Lai Jiangshan
2011-11-05 14:07       ` Mathieu Desnoyers
2011-11-05 13:54     ` [ltt-dev] [PATCH 1/2] rculfhash: rename dummy to bucket Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111105134253.GE15862@Krystal \
    --to=mathieu.desnoyers@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox