From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [ltt-dev] [UST PATCH] Fix missing data pointer
Date: Thu, 30 Sep 2010 15:13:27 -0400 [thread overview]
Message-ID: <20100930191327.GA21242@Krystal> (raw)
In-Reply-To: <1285872775-13949-1-git-send-email-david.goulet@polymtl.ca>
* David Goulet (david.goulet at polymtl.ca) wrote:
> This applies to tracepoint using a marker (trace_mark_tp)
>
> At commit 9dec086e052cf7f583a3afaa3aab48a6de8d38ac,
> the tracepoint_probe_register/unregister_noupdate function has been
> changed with the addition of a void data pointer. In set_marker(),
> the call to that function was not updated with this new parameter.
> The effect was that on a second register_trace with an already
> registered probe, the data ptr was corrupted with false data and
> thus the probe checking failed to validate duplicates. So, the same
> data was reproduced for a single trace call. Same behavior for
> unregistering the marker, it was not found.
>
> NOTE : For now, this pointer is NULL because we don't have at this
> point tracing session.
>
> Signed-off-by: David Goulet <david.goulet at polymtl.ca>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
> libust/marker.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libust/marker.c b/libust/marker.c
> index 0c85cc3..cb8ffc1 100644
> --- a/libust/marker.c
> +++ b/libust/marker.c
> @@ -594,11 +594,11 @@ static int set_marker(struct marker_entry *entry, struct marker *elem,
> //ust// BUG_ON(!ret);
> ret = tracepoint_probe_register_noupdate(
> elem->tp_name,
> - elem->tp_cb);
> + elem->tp_cb, NULL);
> } else {
> ret = tracepoint_probe_unregister_noupdate(
> elem->tp_name,
> - elem->tp_cb);
> + elem->tp_cb, NULL);
> /*
> * tracepoint_probe_update_all() must be called
> * before the module containing tp_cb is unloaded.
> @@ -630,7 +630,7 @@ static void disable_marker(struct marker *elem)
> * checking has been done in the __trace_mark_tp() macro.
> */
> ret = tracepoint_probe_unregister_noupdate(elem->tp_name,
> - elem->tp_cb);
> + elem->tp_cb, NULL);
> WARN_ON(ret);
> /*
> * tracepoint_probe_update_all() must be called
> --
> 1.7.3
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2010-09-30 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 18:52 David Goulet
2010-09-30 19:13 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930191327.GA21242@Krystal \
--to=compudj@krystal.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox