Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [ltt-dev] [PATCH] nfs: add support for splice writes
Date: Tue, 21 Apr 2009 10:48:10 -0400	[thread overview]
Message-ID: <20090421144810.GA7036@infradead.org> (raw)
In-Reply-To: <49EC990B.1030007@suse.de>

On Mon, Apr 20, 2009 at 09:17:23PM +0530, Suresh Jayaraman wrote:
> +static ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe,
> +				     struct file *filp, loff_t *ppos,
> +				     size_t count, unsigned int flags)
> +{
> +	struct dentry *dentry = filp->f_path.dentry;
> +
> +	dprintk("NFS splice_write(%s/%s, %lu@%Lu)\n",
> +		dentry->d_parent->d_name.name, dentry->d_name.name,
> +		(unsigned long) count, (unsigned long long) *ppos);
> +
> +	return generic_file_splice_write(pipe, filp, ppos, count, flags);
> +}
> +

You need all calls from nfs_file_write, too:

 - most importantly the nfs_revalidate_file_size for O_APPEND
 - the nfs_do_fsync for sync writes
 - probably the stats increment




  reply	other threads:[~2009-04-21 14:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  6:21 Suresh Jayaraman
2009-04-02  6:29 ` Mathieu Desnoyers
2009-04-02  6:32 ` Mathieu Desnoyers
2009-04-02  6:42   ` Suresh Jayaraman
2009-04-02 12:42     ` Masahiro Tamori
2009-04-20  5:39       ` Suresh Jayaraman
2009-04-20 12:23         ` Trond Myklebust
2009-04-20 12:38           ` Suresh Jayaraman
2009-04-20 14:21             ` Trond Myklebust
2009-04-20 15:47               ` Suresh Jayaraman
2009-04-21 14:48                 ` Christoph Hellwig [this message]
2009-04-21 17:35                   ` Trond Myklebust
2009-04-21 18:48                     ` Chuck Lever
2009-04-22  8:33                     ` Suresh Jayaraman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090421144810.GA7036@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox