Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: mingo@elte.hu (Ingo Molnar)
Subject: [ltt-dev] [patch 2/9] LTTng instrumentation - irq
Date: Tue, 24 Mar 2009 21:51:20 +0100	[thread overview]
Message-ID: <20090324205120.GB24320@elte.hu> (raw)
In-Reply-To: <20090324201146.GA4350@Krystal>


* Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca> wrote:

> If we want to do this logically, without thinking about tracer 
> performance impact, we could/should do :
> 
> trace_irq_entry(irqno, pt_regs)
>   for_each_handler() {
>     trace_irq_handler_entry(action)
>     action->handler()
>     trace_irq_handler_exit(ret)
>   }
> trace_irq_exit(retval)

Not really.

As i said, the handler invocation should be thought of separately 
from vectored IRQs. A device IRQ handler can be invoked in a number 
of non-vectored ways: it can be called in an IRQ thread for example. 
(there are other invocation modes possible too)

For IRQ vectors, the 'retval' makes little sense - so the exit event 
can be left out.

Which leaves us with what i suggested: to add an IRQ vector entry 
event on top of Jason's (already integrated) patches.

Hm?

	Ingo




  reply	other threads:[~2009-03-24 20:51 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 15:56 [ltt-dev] [patch 0/9] LTTng core kernel instrumentation Mathieu Desnoyers
2009-03-24 15:56 ` [ltt-dev] [patch 1/9] IRQ handle prepare for instrumentation Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56 ` [ltt-dev] [patch 2/9] LTTng instrumentation - irq Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 17:33   ` Jason Baron
2009-03-24 17:50     ` Ingo Molnar
2009-03-24 17:57       ` Jason Baron
2009-03-24 19:12         ` Ingo Molnar
2009-03-24 20:11           ` Mathieu Desnoyers
2009-03-24 20:51             ` Ingo Molnar [this message]
2009-03-25  8:47               ` Ingo Molnar
2009-03-25 18:30                 ` Mathieu Desnoyers
2009-03-25  2:00             ` Steven Rostedt
2009-03-26 18:27               ` Mathieu Desnoyers
2009-03-27 22:53                 ` Steven Rostedt
2009-04-02  2:42                   ` Mathieu Desnoyers
2009-03-25  2:09             ` Steven Rostedt
2009-03-26 18:28               ` Mathieu Desnoyers
2009-03-27 19:18           ` Jason Baron
2009-03-24 19:14   ` Ingo Molnar
2009-03-27 22:12   ` Thomas Gleixner
2009-03-24 15:56 ` [ltt-dev] [patch 3/9] LTTng instrumentation tasklets Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 17:56   ` Ingo Molnar
2009-03-25 13:52     ` Chetan.Loke
2009-03-25 14:17       ` Peter Zijlstra
2009-03-25 17:37         ` Chetan.Loke
2009-03-25 17:52           ` Steven Rostedt
2009-03-24 15:56 ` [ltt-dev] [patch 4/9] LTTng instrumentation softirq Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 18:01   ` Ingo Molnar
2009-03-24 15:56 ` [ltt-dev] [patch 5/9] LTTng instrumentation scheduler fix task migration Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 17:53   ` Ingo Molnar
2009-03-24 15:56 ` [ltt-dev] [patch 6/9] LTTng instrumentation - timer Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 18:21   ` Ingo Molnar
2009-03-24 19:14     ` Thomas Gleixner
2009-03-24 20:47       ` Ingo Molnar
2009-03-27 22:05         ` Thomas Gleixner
2009-03-24 15:56 ` [ltt-dev] [patch 7/9] LTTng instrumentation - kernel Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 18:33   ` Ingo Molnar
2009-03-25  1:13     ` Rusty Russell
2009-03-25  8:40       ` Ingo Molnar
2009-03-25 13:06     ` Frederic Weisbecker
2009-03-24 15:56 ` [ltt-dev] [patch 8/9] LTTng instrumentation - filemap Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 18:39   ` Ingo Molnar
2009-03-24 15:56 ` [ltt-dev] [patch 9/9] LTTng instrumentation - swap Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 15:56   ` Mathieu Desnoyers
2009-03-24 18:51   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324205120.GB24320@elte.hu \
    --to=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox