* [ltt-dev] [PATCH] Don't use select
@ 2009-02-10 7:46 KOSAKI Motohiro
2009-02-11 5:02 ` Mathieu Desnoyers
0 siblings, 1 reply; 5+ messages in thread
From: KOSAKI Motohiro @ 2009-02-10 7:46 UTC (permalink / raw)
Impact: Kconfig cleanup
many kernel developer hate select Kconfig syntax.
it should be avoided.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
ltt/Kconfig | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/ltt/Kconfig b/ltt/Kconfig
index ef93140..1347d6f 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -1,8 +1,8 @@
menuconfig LTT
bool "Linux Trace Toolkit Next Generation (LTTng)"
depends on EXPERIMENTAL
- select MARKERS
- select TRACEPOINTS
+ depends on MARKERS
+ depends on TRACEPOINTS
default y
help
It is possible for the kernel to log important events to a trace
@@ -48,7 +48,7 @@ config LTT_RELAY_ALLOC
config LTT_RELAY
tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
- select DEBUG_FS
+ depends on DEBUG_FS
select LTT_RELAY_ALLOC
depends on LTT_TRACER
default y
@@ -61,7 +61,7 @@ config LTT_RELAY
config LTT_RELAY_LOCKED
tristate "Linux Trace Toolkit Lock-Protected Data Relay"
- select DEBUG_FS
+ depends on DEBUG_FS
select LTT_RELAY_ALLOC
depends on LTT_TRACER
default n
@@ -82,6 +82,7 @@ config LTT_RELAY_CHECK_RANDOM_ACCESS
config LTT_SERIALIZE
tristate "Linux Trace Toolkit Serializer"
default y
+ select LTT_RELAY_ALLOC
help
Library for serializing information from format string and argument
list to the trace buffers.
@@ -182,9 +183,9 @@ config LTT_STATEDUMP
config LTT_FTRACE
bool "Linux Trace Toolkit Function Tracer Support"
- select LTT_SERIALIZE
- select LTT_MARKER_CONTROL
- select FUNCTION_TRACER
+ depends on LTT_SERIALIZE
+ depends on LTT_MARKER_CONTROL
+ depends on FUNCTION_TRACER
default n
help
Integration of function entry trace with LTTng. Connect the
@@ -197,8 +198,8 @@ config LTT_KPROBES
depends on HAVE_KPROBES
depends on LTT_MARKER_CONTROL
depends on LTT_TRACEPROBES=y
- select KPROBES
- select KALLSYMS
+ depends on KPROBES
+ depends on KALLSYMS
default y
help
Allows connecting the LTTng tracer on kprobes using simple debugfs
--
1.6.0.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ltt-dev] [PATCH] Don't use select
2009-02-10 7:46 [ltt-dev] [PATCH] Don't use select KOSAKI Motohiro
@ 2009-02-11 5:02 ` Mathieu Desnoyers
2009-02-11 7:15 ` KOSAKI Motohiro
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Desnoyers @ 2009-02-11 5:02 UTC (permalink / raw)
* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> Impact: Kconfig cleanup
>
> many kernel developer hate select Kconfig syntax.
> it should be avoided.
>
Hrm, about MARKERS, TRACEPOINT, DEBUG_FS, KPROBES, KALLSYMS,
FUNCTION_TRACER, the problem is that it can be frustrating for a user
who does not see the tracing options to figure out where to enable the
dependencies in the menus.
If we really want to remove the select, we'll have to find a more
suitable solution.
Mathieu
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
> ---
> ltt/Kconfig | 19 ++++++++++---------
> 1 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index ef93140..1347d6f 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -1,8 +1,8 @@
> menuconfig LTT
> bool "Linux Trace Toolkit Next Generation (LTTng)"
> depends on EXPERIMENTAL
> - select MARKERS
> - select TRACEPOINTS
> + depends on MARKERS
> + depends on TRACEPOINTS
> default y
> help
> It is possible for the kernel to log important events to a trace
> @@ -48,7 +48,7 @@ config LTT_RELAY_ALLOC
>
> config LTT_RELAY
> tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
> - select DEBUG_FS
> + depends on DEBUG_FS
> select LTT_RELAY_ALLOC
> depends on LTT_TRACER
> default y
> @@ -61,7 +61,7 @@ config LTT_RELAY
>
> config LTT_RELAY_LOCKED
> tristate "Linux Trace Toolkit Lock-Protected Data Relay"
> - select DEBUG_FS
> + depends on DEBUG_FS
> select LTT_RELAY_ALLOC
> depends on LTT_TRACER
> default n
> @@ -82,6 +82,7 @@ config LTT_RELAY_CHECK_RANDOM_ACCESS
> config LTT_SERIALIZE
> tristate "Linux Trace Toolkit Serializer"
> default y
> + select LTT_RELAY_ALLOC
> help
> Library for serializing information from format string and argument
> list to the trace buffers.
> @@ -182,9 +183,9 @@ config LTT_STATEDUMP
>
> config LTT_FTRACE
> bool "Linux Trace Toolkit Function Tracer Support"
> - select LTT_SERIALIZE
> - select LTT_MARKER_CONTROL
> - select FUNCTION_TRACER
> + depends on LTT_SERIALIZE
> + depends on LTT_MARKER_CONTROL
> + depends on FUNCTION_TRACER
> default n
> help
> Integration of function entry trace with LTTng. Connect the
> @@ -197,8 +198,8 @@ config LTT_KPROBES
> depends on HAVE_KPROBES
> depends on LTT_MARKER_CONTROL
> depends on LTT_TRACEPROBES=y
> - select KPROBES
> - select KALLSYMS
> + depends on KPROBES
> + depends on KALLSYMS
> default y
> help
> Allows connecting the LTTng tracer on kprobes using simple debugfs
> --
> 1.6.0.6
>
>
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ltt-dev] [PATCH] Don't use select
2009-02-11 5:02 ` Mathieu Desnoyers
@ 2009-02-11 7:15 ` KOSAKI Motohiro
2009-02-11 7:21 ` Mathieu Desnoyers
0 siblings, 1 reply; 5+ messages in thread
From: KOSAKI Motohiro @ 2009-02-11 7:15 UTC (permalink / raw)
> * KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > Impact: Kconfig cleanup
> >
> > many kernel developer hate select Kconfig syntax.
> > it should be avoided.
> >
>
> Hrm, about MARKERS, TRACEPOINT, DEBUG_FS, KPROBES, KALLSYMS,
> FUNCTION_TRACER, the problem is that it can be frustrating for a user
> who does not see the tracing options to figure out where to enable the
> dependencies in the menus.
>
> If we really want to remove the select, we'll have to find a more
> suitable solution.
I can understand your point.
but, "select" syntax discussion freqently repeated on LKML.
at least, akpm strongly dislike it. (please google past discssion)
Then, I think "select" make hardly mainline merging.
In other view, .config is edited _by_ developer, not end user.
We can assume they can understand Kconfig file. Kconfig itself clearly
described dependencies.
However, if you have strongly opinion, I don't oppose it.
Myself don't dislike "select", I merely want to merge lttng to mainline easily.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ltt-dev] [PATCH] Don't use select
2009-02-11 7:15 ` KOSAKI Motohiro
@ 2009-02-11 7:21 ` Mathieu Desnoyers
2009-02-11 8:07 ` KOSAKI Motohiro
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Desnoyers @ 2009-02-11 7:21 UTC (permalink / raw)
* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > * KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > > Impact: Kconfig cleanup
> > >
> > > many kernel developer hate select Kconfig syntax.
> > > it should be avoided.
> > >
> >
> > Hrm, about MARKERS, TRACEPOINT, DEBUG_FS, KPROBES, KALLSYMS,
> > FUNCTION_TRACER, the problem is that it can be frustrating for a user
> > who does not see the tracing options to figure out where to enable the
> > dependencies in the menus.
> >
> > If we really want to remove the select, we'll have to find a more
> > suitable solution.
>
> I can understand your point.
> but, "select" syntax discussion freqently repeated on LKML.
> at least, akpm strongly dislike it. (please google past discssion)
>
> Then, I think "select" make hardly mainline merging.
>
>
> In other view, .config is edited _by_ developer, not end user.
> We can assume they can understand Kconfig file. Kconfig itself clearly
> described dependencies.
>
>
> However, if you have strongly opinion, I don't oppose it.
> Myself don't dislike "select", I merely want to merge lttng to mainline easily.
>
Another solution would be to bring together all the related options
(ftrace, debugfs, kprobes, lttng, ...) so they are clearly all available
in the same menu. What do you think ?
Mathieu
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ltt-dev] [PATCH] Don't use select
2009-02-11 7:21 ` Mathieu Desnoyers
@ 2009-02-11 8:07 ` KOSAKI Motohiro
0 siblings, 0 replies; 5+ messages in thread
From: KOSAKI Motohiro @ 2009-02-11 8:07 UTC (permalink / raw)
> > However, if you have strongly opinion, I don't oppose it.
> > Myself don't dislike "select", I merely want to merge lttng to mainline easily.
>
> Another solution would be to bring together all the related options
> (ftrace, debugfs, kprobes, lttng, ...) so they are clearly all available
> in the same menu. What do you think ?
Cool!
I love this idea :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-11 8:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-10 7:46 [ltt-dev] [PATCH] Don't use select KOSAKI Motohiro
2009-02-11 5:02 ` Mathieu Desnoyers
2009-02-11 7:15 ` KOSAKI Motohiro
2009-02-11 7:21 ` Mathieu Desnoyers
2009-02-11 8:07 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox