From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [ltt-dev] [PATCH 4/4] Define string arguments as const for trace control functions
Date: Fri, 24 Oct 2008 10:28:43 -0400 [thread overview]
Message-ID: <20081024142843.GG24251@Krystal> (raw)
In-Reply-To: <20081024142522.GF24251@Krystal>
* Mathieu Desnoyers (compudj at krystal.dyndns.org) wrote:
> * Zhaolei (zhaolei at cn.fujitsu.com) wrote:
[...]
> > @@ -714,7 +714,7 @@ static int ltt_trace_stop(char *trace_name)
> > * @trace_type : Type of trace (normal, flight, hybrid)
> > * @args : Arguments specific to the action
> > */
> > -int ltt_control(enum ltt_control_msg msg, char *trace_name, char *trace_type,
> > +int ltt_control(enum ltt_control_msg msg, const char *trace_name, const char *trace_type,
> > union ltt_control_args args)
> > {
> > int err = EPERM;
compudj at ok:~/git/morestable/linux-2.6-lttng$ scripts/checkpatch.pl patches/`quilt top`
WARNING: line over 80 characters
#97: FILE: ltt/ltt-tracer.c:698:
+int ltt_control(enum ltt_control_msg msg, const char *trace_name, const char *trace_type,
total: 0 errors, 1 warnings, 82 lines checked
I fixed the patch in my tree. I just email this as a reminder to use
checkpatch ;) (it looks like Andrew Morton eventually converted me to
checkpatch zealotness after all)
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2008-10-24 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 10:47 Zhaolei
2008-10-24 14:25 ` Mathieu Desnoyers
2008-10-24 14:28 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024142843.GG24251@Krystal \
--to=compudj@krystal.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox