From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Fri, 24 Oct 2008 10:28:43 -0400
Subject: [ltt-dev] [PATCH 4/4] Define string arguments as const
	for	trace control functions
In-Reply-To: <20081024142522.GF24251@Krystal>
References: <49005643.6020401@cn.fujitsu.com> <20081024142522.GF24251@Krystal>
Message-ID: <20081024142843.GG24251@Krystal>

* Mathieu Desnoyers (compudj at krystal.dyndns.org) wrote:
> * Zhaolei (zhaolei at cn.fujitsu.com) wrote:
[...]
> > @@ -714,7 +714,7 @@ static int ltt_trace_stop(char *trace_name)
> >   * @trace_type : Type of trace (normal, flight, hybrid)
> >   * @args : Arguments specific to the action
> >   */
> > -int ltt_control(enum ltt_control_msg msg, char *trace_name, char *trace_type,
> > +int ltt_control(enum ltt_control_msg msg, const char *trace_name, const char *trace_type,
> >  		union ltt_control_args args)
> >  {
> >  	int err = EPERM;


compudj at ok:~/git/morestable/linux-2.6-lttng$ scripts/checkpatch.pl patches/`quilt top`
WARNING: line over 80 characters
#97: FILE: ltt/ltt-tracer.c:698:
+int ltt_control(enum ltt_control_msg msg, const char *trace_name, const char *trace_type,

total: 0 errors, 1 warnings, 82 lines checked

I fixed the patch in my tree. I just email this as a reminder to use
checkpatch ;) (it looks like Andrew Morton eventually converted me to
checkpatch zealotness after all)

Mathieu

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68