[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Alan D. Brunelle]

I'm attempting to try out LTTng, but ran into this error after the
following steps:

(1) Git tree w/ Linus' "latest" tree - 2.6.27-rc8 (commit
4a7703582836f55a1cbad0e2c1c6ebbee3f9b3a7)

(2) Expanded patch-2.6.27-rc7-lttng-0.27.tar.bz2 into 'patches' directory

(3) Ran 'quilt push -a' which seemed to make a lot of patches...

(4) ran make:

  CC      ltt/ltt-tracer.o
ltt/ltt-tracer.c: In function ?ltt_control?:
ltt/ltt-tracer.c:386: warning: ?trace? may be used uninitialized in this
function
ltt/ltt-tracer.c:386: note: ?trace? was declared here
  CC      ltt/ltt-relay.o
  CC      ltt/ltt-relay-alloc.o
ltt/ltt-relay-alloc.c: In function ?relay_alloc_buf?:
ltt/ltt-relay-alloc.c:46: error: ?cpu? undeclared (first use in this
function)
ltt/ltt-relay-alloc.c:46: error: (Each undeclared identifier is reported
only once
ltt/ltt-relay-alloc.c:46: error: for each function it appears in.)
make[1]: *** [ltt/ltt-relay-alloc.o] Error 1
make: *** [ltt] Error 2


Looking at the patch patches/lttng-relay-alloc.patch shows that the
problem is in the patch.

Is this an issue w/ 2.6.27-rc8, and I should go back down to 2.6.27-rc7
- or is there just a bad patch?

Thanks,
Alan

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

Thanks for the report, it should be fixed in LTTng 0.28, now available.

Mathieu

* Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> I'm attempting to try out LTTng, but ran into this error after the
> following steps:
> 
> (1) Git tree w/ Linus' "latest" tree - 2.6.27-rc8 (commit
> 4a7703582836f55a1cbad0e2c1c6ebbee3f9b3a7)
> 
> (2) Expanded patch-2.6.27-rc7-lttng-0.27.tar.bz2 into 'patches' directory
> 
> (3) Ran 'quilt push -a' which seemed to make a lot of patches...
> 
> (4) ran make:
> 
>   CC      ltt/ltt-tracer.o
> ltt/ltt-tracer.c: In function ?ltt_control?:
> ltt/ltt-tracer.c:386: warning: ?trace? may be used uninitialized in this
> function
> ltt/ltt-tracer.c:386: note: ?trace? was declared here
>   CC      ltt/ltt-relay.o
>   CC      ltt/ltt-relay-alloc.o
> ltt/ltt-relay-alloc.c: In function ?relay_alloc_buf?:
> ltt/ltt-relay-alloc.c:46: error: ?cpu? undeclared (first use in this
> function)
> ltt/ltt-relay-alloc.c:46: error: (Each undeclared identifier is reported
> only once
> ltt/ltt-relay-alloc.c:46: error: for each function it appears in.)
> make[1]: *** [ltt/ltt-relay-alloc.o] Error 1
> make: *** [ltt] Error 2
> 
> 
> Looking at the patch patches/lttng-relay-alloc.patch shows that the
> problem is in the patch.
> 
> Is this an issue w/ 2.6.27-rc8, and I should go back down to 2.6.27-rc7
> - or is there just a bad patch?
> 
> Thanks,
> Alan
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Pierre-Marc Fournier]

0.27 introduced major and experimental changes. I'm sure Mathieu will 
fix this as soon as he reads your post. But if you want to get running 
quickly:

- You could go back to 0.26, which was pretty stable and also applies to 
2.6.27-rc7, probably -rc8 too.
- Alternatively you could use the LTTng git repository at:

http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary

You will find the kernel tree with the patches already applied there.

pmf

Alan D. Brunelle wrote:
> I'm attempting to try out LTTng, but ran into this error after the
> following steps:
> 
> (1) Git tree w/ Linus' "latest" tree - 2.6.27-rc8 (commit
> 4a7703582836f55a1cbad0e2c1c6ebbee3f9b3a7)
> 
> (2) Expanded patch-2.6.27-rc7-lttng-0.27.tar.bz2 into 'patches' directory
> 
> (3) Ran 'quilt push -a' which seemed to make a lot of patches...
> 
> (4) ran make:
> 
>   CC      ltt/ltt-tracer.o
> ltt/ltt-tracer.c: In function ?ltt_control?:
> ltt/ltt-tracer.c:386: warning: ?trace? may be used uninitialized in this
> function
> ltt/ltt-tracer.c:386: note: ?trace? was declared here
>   CC      ltt/ltt-relay.o
>   CC      ltt/ltt-relay-alloc.o
> ltt/ltt-relay-alloc.c: In function ?relay_alloc_buf?:
> ltt/ltt-relay-alloc.c:46: error: ?cpu? undeclared (first use in this
> function)
> ltt/ltt-relay-alloc.c:46: error: (Each undeclared identifier is reported
> only once
> ltt/ltt-relay-alloc.c:46: error: for each function it appears in.)
> make[1]: *** [ltt/ltt-relay-alloc.o] Error 1
> make: *** [ltt] Error 2
> 
> 
> Looking at the patch patches/lttng-relay-alloc.patch shows that the
> problem is in the patch.
> 
> Is this an issue w/ 2.6.27-rc8, and I should go back down to 2.6.27-rc7
> - or is there just a bad patch?
> 
> Thanks,
> Alan
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Alan D. Brunelle]

Pierre-Marc Fournier wrote:
> 0.27 introduced major and experimental changes. I'm sure Mathieu will
> fix this as soon as he reads your post. But if you want to get running
> quickly:
> 
> - You could go back to 0.26, which was pretty stable and also applies to
> 2.6.27-rc7, probably -rc8 too.
> - Alternatively you could use the LTTng git repository at:
> 
> http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> 
> 
> You will find the kernel tree with the patches already applied there.
> 
> pmf

Thanks much - that's probably _much_ easier than trying to hand patch
this stuff (having never used quilt, it seems to be messing up my
'linus' git tree...)

Alan

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

* Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> Pierre-Marc Fournier wrote:
> > 0.27 introduced major and experimental changes. I'm sure Mathieu will
> > fix this as soon as he reads your post. But if you want to get running
> > quickly:
> > 
> > - You could go back to 0.26, which was pretty stable and also applies to
> > 2.6.27-rc7, probably -rc8 too.
> > - Alternatively you could use the LTTng git repository at:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> > 
> > 
> > You will find the kernel tree with the patches already applied there.
> > 
> > pmf
> 
> Thanks much - that's probably _much_ easier than trying to hand patch
> this stuff (having never used quilt, it seems to be messing up my
> 'linus' git tree...)
> 

Well, the build issue was introduced just before the release and by
using cpu_to_node() which is defined out on my setup.

Hopefully, everything should be smooth now.

Mathieu

> Alan
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Alan D. Brunelle]

Pierre-Marc Fournier wrote:
> 0.27 introduced major and experimental changes. I'm sure Mathieu will
> fix this as soon as he reads your post. But if you want to get running
> quickly:
> 
> - You could go back to 0.26, which was pretty stable and also applies to
> 2.6.27-rc7, probably -rc8 too.
> - Alternatively you could use the LTTng git repository at:
> 
> http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> 
> 
> You will find the kernel tree with the patches already applied there.
> 
> pmf

git clone
git://git.kernel.org/pub/scm/linux/kernel/git/compudj/linux-2.6-lttng.git

works better - the http version complains:

Cannot get remote repository information.
Perhaps git-update-server-info needs to be run there?

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

* Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> Pierre-Marc Fournier wrote:
> > 0.27 introduced major and experimental changes. I'm sure Mathieu will
> > fix this as soon as he reads your post. But if you want to get running
> > quickly:
> > 
> > - You could go back to 0.26, which was pretty stable and also applies to
> > 2.6.27-rc7, probably -rc8 too.
> > - Alternatively you could use the LTTng git repository at:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> > 
> > 
> > You will find the kernel tree with the patches already applied there.
> > 
> > pmf
> 
> git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/compudj/linux-2.6-lttng.git
> 
> works better - the http version complains:
> 
> Cannot get remote repository information.
> Perhaps git-update-server-info needs to be run there?
> 

Done.

Note that you'll get 0.28 if you select the HEAD.

Mathieu

> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

* Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> Pierre-Marc Fournier wrote:
> > 0.27 introduced major and experimental changes. I'm sure Mathieu will
> > fix this as soon as he reads your post. But if you want to get running
> > quickly:
> > 
> > - You could go back to 0.26, which was pretty stable and also applies to
> > 2.6.27-rc7, probably -rc8 too.
> > - Alternatively you could use the LTTng git repository at:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> > 
> > 
> > You will find the kernel tree with the patches already applied there.
> > 
> > pmf
> 
> git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/compudj/linux-2.6-lttng.git
> 
> works better - the http version complains:
> 
> Cannot get remote repository information.
> Perhaps git-update-server-info needs to be run there?
> 

I've updated head to 2.6.27-rc8 with LTTng 0.29.

Mathieu

> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

* Mathieu Desnoyers (compudj at krystal.dyndns.org) wrote:
> * Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> > Pierre-Marc Fournier wrote:
> > > 0.27 introduced major and experimental changes. I'm sure Mathieu will
> > > fix this as soon as he reads your post. But if you want to get running
> > > quickly:
> > > 
> > > - You could go back to 0.26, which was pretty stable and also applies to
> > > 2.6.27-rc7, probably -rc8 too.
> > > - Alternatively you could use the LTTng git repository at:
> > > 
> > > http://git.kernel.org/?p=linux/kernel/git/compudj/linux-2.6-lttng.git;a=summary
> > > 
> > > 
> > > You will find the kernel tree with the patches already applied there.
> > > 
> > > pmf
> > 
> > git clone
> > git://git.kernel.org/pub/scm/linux/kernel/git/compudj/linux-2.6-lttng.git
> > 
> > works better - the http version complains:
> > 
> > Cannot get remote repository information.
> > Perhaps git-update-server-info needs to be run there?
> > 
> 
> I've updated head to 2.6.27-rc8 with LTTng 0.29.
> 

Forgot a second cpu_to_node() use. fixed in 0.30.

Mathieu

> Mathieu
> 
> > _______________________________________________
> > ltt-dev mailing list
> > ltt-dev at lists.casi.polymtl.ca
> > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> > 
> 
> -- 
> Mathieu Desnoyers
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Alan D. Brunelle]

Hi Mathieu -

As of:

commit d3d8fedafe7f370885b2799c0610ded1e28e0627
Author: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
Date:   Thu Oct 2 12:01:12 2008 -0400

    lockdep-check-spinlock-irq-state

These changes don't appear (of course), and 'git pull' isn't bringing
anything further in. Could you push your changes out to kernel.org?

Thanks,
Alan

[ltt-dev] ltt/ltt-relay-alloc.c:46: error: 'cpu' undeclared

[Mathieu Desnoyers]

They are on kernel.org, but you are probably pulling from an old branch.
Given I rebase my work at every version, I publish it under a new branch
name each time and link HEAD to that new branch.

The other possibility is that kernel.org mirrors take time to update. It
would be updated faster if you pull from ltt.polymtl.ca.

Mathieu

* Alan D. Brunelle (Alan.Brunelle at hp.com) wrote:
> Hi Mathieu -
> 
> As of:
> 
> commit d3d8fedafe7f370885b2799c0610ded1e28e0627
> Author: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> Date:   Thu Oct 2 12:01:12 2008 -0400
> 
>     lockdep-check-spinlock-irq-state
> 
> These changes don't appear (of course), and 'git pull' isn't bringing
> anything further in. Could you push your changes out to kernel.org?
> 
> Thanks,
> Alan
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68