Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
* [lttng-dev] [PATCH lttng-ust] Fix: Fix self-assign warning on struct ustfork_clone_info init
@ 2012-10-23 19:37 Christian Babeux
  2012-10-23 19:59 ` Mathieu Desnoyers
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Babeux @ 2012-10-23 19:37 UTC (permalink / raw)


Use the proper field designator syntax (C99) to initialize the
ustfork_clone_info struct.

Signed-off-by: Christian Babeux <christian.babeux at efficios.com>
---
 liblttng-ust-fork/ustfork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 liblttng-ust-fork/ustfork.c

diff --git a/liblttng-ust-fork/ustfork.c b/liblttng-ust-fork/ustfork.c
old mode 100644
new mode 100755
index 13f77cf..34f674c
--- a/liblttng-ust-fork/ustfork.c
+++ b/liblttng-ust-fork/ustfork.c
@@ -139,7 +139,7 @@ int clone(int (*fn)(void *), void *child_stack, int flags, void *arg, ...)
 				tls, ctid);
 	} else {
 		/* Creating a real process, we need to intervene. */
-		struct ustfork_clone_info info = { fn = fn, arg = arg };
+		struct ustfork_clone_info info = { .fn = fn, .arg = arg };
 
 		ust_before_fork(&info.sigset);
 		retval = plibc_func(clone_fn, child_stack, flags, &info,
-- 
1.7.12.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [lttng-dev] [PATCH lttng-ust] Fix: Fix self-assign warning on struct ustfork_clone_info init
  2012-10-23 19:37 [lttng-dev] [PATCH lttng-ust] Fix: Fix self-assign warning on struct ustfork_clone_info init Christian Babeux
@ 2012-10-23 19:59 ` Mathieu Desnoyers
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers @ 2012-10-23 19:59 UTC (permalink / raw)


* Christian Babeux (christian.babeux at efficios.com) wrote:
> Use the proper field designator syntax (C99) to initialize the
> ustfork_clone_info struct.

merged, thanks!

Mathieu

> 
> Signed-off-by: Christian Babeux <christian.babeux at efficios.com>
> ---
>  liblttng-ust-fork/ustfork.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 liblttng-ust-fork/ustfork.c
> 
> diff --git a/liblttng-ust-fork/ustfork.c b/liblttng-ust-fork/ustfork.c
> old mode 100644
> new mode 100755
> index 13f77cf..34f674c
> --- a/liblttng-ust-fork/ustfork.c
> +++ b/liblttng-ust-fork/ustfork.c
> @@ -139,7 +139,7 @@ int clone(int (*fn)(void *), void *child_stack, int flags, void *arg, ...)
>  				tls, ctid);
>  	} else {
>  		/* Creating a real process, we need to intervene. */
> -		struct ustfork_clone_info info = { fn = fn, arg = arg };
> +		struct ustfork_clone_info info = { .fn = fn, .arg = arg };
>  
>  		ust_before_fork(&info.sigset);
>  		retval = plibc_func(clone_fn, child_stack, flags, &info,
> -- 
> 1.7.12.2
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-23 19:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-23 19:37 [lttng-dev] [PATCH lttng-ust] Fix: Fix self-assign warning on struct ustfork_clone_info init Christian Babeux
2012-10-23 19:59 ` Mathieu Desnoyers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox