[ltt-dev] [UST PATCH] Only send the pids that are currently online in ustctl_get_online_pids().

* [ltt-dev] [UST PATCH] Only send the pids that are currently online in ustctl_get_online_pids().
@ 2011-04-01 20:35 Matthew Khouzam
  2011-04-01 20:42 ` Mathieu Desnoyers
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Khouzam @ 2011-04-01 20:35 UTC (permalink / raw)


Signed-off-by: Matthew Khouzam <matthew.khouzam at ericsson.com>
---
 libustctl/libustctl.c |   19 ++++++++++++++++++-
 1 files changed, 18 insertions(+), 1 deletions(-)

diff --git a/libustctl/libustctl.c b/libustctl/libustctl.c
index d57e645..07c81f3 100644
--- a/libustctl/libustctl.c
+++ b/libustctl/libustctl.c
@@ -92,6 +92,8 @@ pid_t *ustctl_get_online_pids(void)
 {
 	struct dirent *dirent;
 	DIR *dir;
+	DIR *proc_dir;
+	char proc_dir_path[PATH_MAX];
 	unsigned int ret_size = 1 * sizeof(pid_t), i = 0;
 
 	dir = opendir(SOCK_DIR);
@@ -117,7 +119,22 @@ pid_t *ustctl_get_online_pids(void)
 			 * We need to figure out an intelligent way of solving
 			 * this, maybe connect-disconnect.
 			 */
-			if (1) {
+			 snprintf(proc_dir_path, PATH_MAX, "/proc/%u/", ret[i]);
+			 proc_dir = opendir(proc_dir_path);
+			 /*
+			  * Note:
+			  * We should not remove the empty dir in this pass.
+			  * A process can die, a new process can be born and
+			  * assigned to that PID. the only way to avoid this
+			  * would be to de-register and register centrally.
+			  * Ltt-sessiond would be a good candidate for such a
+			  * location.
+			  */
+			 if (proc_dir) {
+				/* We only needed to check if it's valid
+				 * so we close it here
+				 */
+				closedir(proc_dir);
 				ret_size += sizeof(pid_t);
 				ret = (pid_t *) realloc(ret, ret_size);
 				++i;
-- 
1.7.0.4





^ permalink raw reply	[flat|nested] 3+ messages in thread