Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: yannick.brosseau@gmail.com (Yannick Brosseau)
Subject: [ltt-dev] [UST PATCH] Fix segfault in ust_fork
Date: Fri, 18 Feb 2011 14:20:45 -0500	[thread overview]
Message-ID: <1298056845-32690-1-git-send-email-yannick.brosseau@gmail.com> (raw)

Move the ltt_trace_destroy after the iteration of open_buffer_list. The destroy
free the pointers used in the open_buffer_list

Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
 libust/tracectl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/libust/tracectl.c b/libust/tracectl.c
index d32deba..1bd7229 100644
--- a/libust/tracectl.c
+++ b/libust/tracectl.c
@@ -1581,7 +1581,6 @@ static void ust_fork(void)
 	ltt_unlock_traces();
 
 	ltt_trace_stop("auto");
-	ltt_trace_destroy("auto", 1);
 	/* Delete all active connections, but leave them in the epoll set */
 	cds_list_for_each_entry_safe(sock, sock_tmp, &ust_socks, list) {
 		ustcomm_del_sock(sock, 1);
@@ -1601,6 +1600,8 @@ static void ust_fork(void)
 		cds_list_del(&buf->open_buffers_list);
 	}
 
+	ltt_trace_destroy("auto", 1);
+
 	/* Clean up the listener socket and epoll, keeping the scoket file */
 	ustcomm_del_named_sock(listen_sock, 1);
 	close(epoll_fd);
-- 
1.7.2.3




             reply	other threads:[~2011-02-18 19:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 19:20 Yannick Brosseau [this message]
2011-02-18 20:15 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298056845-32690-1-git-send-email-yannick.brosseau@gmail.com \
    --to=yannick.brosseau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox