Re: Why does symfile.c use printf_filtered?

[Jim Blandy <jimb@redhat.com>]

"J. Johnston" <jjohnstn@redhat.com> writes:

> Does anybody know why symfile.c uses printf_filtered()?
> 
> This causes a couple of problems, most notably when you load a module
> with a lot of shared library references.  The messages for "Reading
> symbols from"... inside symfile.c are printed filtered so eventually
> we end up causing a page break.  I do not think this information is
> worthy of requiring user intervention.
> 
> Would anybody have an objection to me changing to use
> printf_unfiltered() in symfile.c?

No, that'd be fine.

I have to wonder, though --- if one doesn't care whether the messages
are scrolling off the screen or not, should one print them at all?
What would folks think of just ditching the fprintf altogether, and
making sure there's some general message that says it's reading
symbols?

I suppose those messages are nice in that they provide a context for
any error messages that might come afterwards, but I think it'd be
better just to improve the error messages to mention the filename
involved, rather than spew stuff all the time on the off chance
something will go wrong.