From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12566 invoked by alias); 22 Oct 2003 22:14:15 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 12553 invoked from network); 22 Oct 2003 22:14:14 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 22 Oct 2003 22:14:14 -0000 Received: by zenia.home (Postfix, from userid 5433) id 1D47E20766; Wed, 22 Oct 2003 17:14:04 -0500 (EST) To: "J. Johnston" Cc: gdb@sources.redhat.com Subject: Re: Why does symfile.c use printf_filtered? References: <3F95A56F.3090802@redhat.com> From: Jim Blandy Date: Wed, 22 Oct 2003 22:14:00 -0000 In-Reply-To: <3F95A56F.3090802@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00252.txt.bz2 "J. Johnston" writes: > Does anybody know why symfile.c uses printf_filtered()? > > This causes a couple of problems, most notably when you load a module > with a lot of shared library references. The messages for "Reading > symbols from"... inside symfile.c are printed filtered so eventually > we end up causing a page break. I do not think this information is > worthy of requiring user intervention. > > Would anybody have an objection to me changing to use > printf_unfiltered() in symfile.c? No, that'd be fine. I have to wonder, though --- if one doesn't care whether the messages are scrolling off the screen or not, should one print them at all? What would folks think of just ditching the fprintf altogether, and making sure there's some general message that says it's reading symbols? I suppose those messages are nice in that they provide a context for any error messages that might come afterwards, but I think it'd be better just to improve the error messages to mention the filename involved, rather than spew stuff all the time on the off chance something will go wrong.