Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: gdb@sourceware.org
Subject: Re: A little patch for two comments in infrun.c
Date: Tue, 30 May 2006 18:40:00 -0000	[thread overview]
Message-ID: <vt2hd371joj.fsf@theseus.home.> (raw)
In-Reply-To: <Pine.LNX.4.64.0605301602590.2773@localhost.localdomain> (Wu Zhou's message of "Tue, 30 May 2006 16:24:11 +0800 (CST)")



Wu Zhou <woodzltc@cn.ibm.com> writes:
> --- infrun.c.orig	2006-05-29 23:52:47.000000000 -0700
> +++ infrun.c	2006-05-29 23:53:24.000000000 -0700
> @@ -531,9 +531,6 @@ resume (int step, enum target_signal sig
>      fprintf_unfiltered (gdb_stdlog, "infrun: resume (step=%d, signal=%d)\n",
>  			step, sig);
>  
> -  /* FIXME: calling breakpoint_here_p (read_pc ()) three times! */
> -
> -
>    /* Some targets (e.g. Solaris x86) have a kernel bug when stepping
>       over an instruction that causes a page fault without triggering
>       a hardware watchpoint. The kernel properly notices that it shouldn't
> @@ -1290,7 +1287,7 @@ handle_inferior_event (struct execution_
>  
>    flush_cached_frames ();
>  
> -  /* If it's a new process, add it to the thread database */
> +  /* If it's a new thread, add it to the thread database */
>  
>    ecs->new_thread_event = (!ptid_equal (ecs->ptid, inferior_ptid)
>  			   && !ptid_equal (ecs->ptid, minus_one_ptid)
>

This looks right to me (with an appropriate (trivial) ChangeLog entry,
of course).  But let's wait a bit to see if anyone more familiar with
infrun.c comments.


  reply	other threads:[~2006-05-30 18:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-30 17:14 Wu Zhou
2006-05-30 18:40 ` Jim Blandy [this message]
2006-05-30 18:48 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2hd371joj.fsf@theseus.home. \
    --to=jimb@codesourcery.com \
    --cc=gdb@sourceware.org \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox