From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22940 invoked by alias); 30 May 2006 18:23:28 -0000 Received: (qmail 22773 invoked by uid 22791); 30 May 2006 18:23:26 -0000 X-Spam-Check-By: sourceware.org Received: from yosemite.airs.com (HELO yosemite.airs.com) (205.217.158.180) by sourceware.org (qpsmtpd/0.31) with SMTP; Tue, 30 May 2006 18:23:24 +0000 Received: (qmail 8559 invoked from network); 30 May 2006 17:56:41 -0000 Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by yosemite.airs.com with SMTP; 30 May 2006 17:56:41 -0000 Received: (qmail 22057 invoked from network); 30 May 2006 17:55:41 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 May 2006 17:55:41 -0000 To: Wu Zhou Cc: gdb@sourceware.org Subject: Re: A little patch for two comments in infrun.c References: From: Jim Blandy Date: Tue, 30 May 2006 18:40:00 -0000 In-Reply-To: (Wu Zhou's message of "Tue, 30 May 2006 16:24:11 +0800 (CST)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00399.txt.bz2 Wu Zhou writes: > --- infrun.c.orig 2006-05-29 23:52:47.000000000 -0700 > +++ infrun.c 2006-05-29 23:53:24.000000000 -0700 > @@ -531,9 +531,6 @@ resume (int step, enum target_signal sig > fprintf_unfiltered (gdb_stdlog, "infrun: resume (step=%d, signal=%d)\n", > step, sig); > > - /* FIXME: calling breakpoint_here_p (read_pc ()) three times! */ > - > - > /* Some targets (e.g. Solaris x86) have a kernel bug when stepping > over an instruction that causes a page fault without triggering > a hardware watchpoint. The kernel properly notices that it shouldn't > @@ -1290,7 +1287,7 @@ handle_inferior_event (struct execution_ > > flush_cached_frames (); > > - /* If it's a new process, add it to the thread database */ > + /* If it's a new thread, add it to the thread database */ > > ecs->new_thread_event = (!ptid_equal (ecs->ptid, inferior_ptid) > && !ptid_equal (ecs->ptid, minus_one_ptid) > This looks right to me (with an appropriate (trivial) ChangeLog entry, of course). But let's wait a bit to see if anyone more familiar with infrun.c comments.