Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: "Neal E. Coombes" <nealc@trdlnk.com>
Cc: gdb@sources.redhat.com
Subject: Re: dbxread.c:1771: internal-error: sect_index_data not initialized
Date: Thu, 18 Sep 2003 22:41:00 -0000	[thread overview]
Message-ID: <vt265jpiux4.fsf@zenia.home> (raw)
In-Reply-To: <3F68C117.3010007@trdlnk.com>


"Neal E. Coombes" <nealc@trdlnk.com> writes:
> We modified the patch to do the change at the ?root? of the problem
> instead of in the specific section.  Please let me know if this will
> have any ill effects (since we certainly don't know as much about gdb
> as the rest of you).

(Please post patches in either unified form or context form.  Diff's
default output mode is not useful if the file has changed elsewhere
since the diff was made --- which is often the case here.)

Unfortunately, this revision isn't right.  

Falling back to the .bss section's offset when no .data offset is
available makes sense (sort of) when we're not really sure which
section contains the object whose address we're relocating.  If there
is no .data section, the object certainly isn't there, so it's a
decent guess that it belongs in .bss.

But there are other cases where we know for sure that the symbol is in
the .data section, not the .bss section.  In those cases, if we have
no .data section offset, then GDB is in an inconsistent state, and
should crash.  It's not correct to fall back to the .bss section.


  reply	other threads:[~2003-09-18 22:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17 15:02 Neal E. Coombes
2003-09-17 17:54 ` Jim Blandy
2003-09-17 18:17   ` Andrew Cagney
2003-09-17 20:16     ` Neal E. Coombes
2003-09-18 22:41       ` Jim Blandy [this message]
2003-09-19 14:04         ` Neal E. Coombes
2003-09-18 22:34     ` Jim Blandy
2003-09-18 22:57       ` Andrew Cagney
2003-09-18 23:12         ` Jim Blandy
2003-09-19 19:45           ` Andrew Cagney
2003-09-17 17:54 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt265jpiux4.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=nealc@trdlnk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox