From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2519 invoked by alias); 18 Sep 2003 22:41:31 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 2512 invoked from network); 18 Sep 2003 22:41:30 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 18 Sep 2003 22:41:30 -0000 Received: by zenia.home (Postfix, from userid 5433) id 17CF720758; Thu, 18 Sep 2003 17:38:47 -0500 (EST) To: "Neal E. Coombes" Cc: gdb@sources.redhat.com Subject: Re: dbxread.c:1771: internal-error: sect_index_data not initialized References: <3F687799.5050201@trdlnk.com> <3F68A535.8010609@redhat.com> <3F68C117.3010007@trdlnk.com> From: Jim Blandy Date: Thu, 18 Sep 2003 22:41:00 -0000 In-Reply-To: <3F68C117.3010007@trdlnk.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00232.txt.bz2 "Neal E. Coombes" writes: > We modified the patch to do the change at the ?root? of the problem > instead of in the specific section. Please let me know if this will > have any ill effects (since we certainly don't know as much about gdb > as the rest of you). (Please post patches in either unified form or context form. Diff's default output mode is not useful if the file has changed elsewhere since the diff was made --- which is often the case here.) Unfortunately, this revision isn't right. Falling back to the .bss section's offset when no .data offset is available makes sense (sort of) when we're not really sure which section contains the object whose address we're relocating. If there is no .data section, the object certainly isn't there, so it's a decent guess that it belongs in .bss. But there are other cases where we know for sure that the symbol is in the .data section, not the .bss section. In those cases, if we have no .data section offset, then GDB is in an inconsistent state, and should crash. It's not correct to fall back to the .bss section.