From: Tom Tromey <tromey@redhat.com>
To: nickrob@snap.net.nz (Nick Roberts)
Cc: "Marc Khouzam" <marc.khouzam@ericsson.com>, <gdb@sourceware.org>
Subject: Re: [RFC] Queries and frontends
Date: Wed, 29 Jul 2009 21:13:00 -0000 [thread overview]
Message-ID: <m3r5vztcpw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <19054.23189.193878.534661@totara.tehura.co.nz> (Nick Roberts's message of "Tue\, 28 Jul 2009 13\:55\:33 +1200")
>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
Tom> Since "server" is intended to hide commands from the user, why check
Tom> server_command at one particular query rather than in every query?
Nick> Because that would change existing behaviour. It's probably a
Nick> small risk as no one else appears to be using the server prefix
Nick> or, if they are, they have kept a very low profile. Just changing
Nick> "record stop" is sufficient for Emacs at the moment. You could
Nick> say it's quick and nasty but I would call it pragmatic.
It seems to me that this is just a bug in the server prefix. The intent
is to hide some actions from the user. But, a query is definitely not
hidden.
My concern with the one-off is that it is unclear why the check is where
it is. And the answer, when someone in the future looks it up, will be
"Emacs needed that".
I tend to think that the more generic change would be safe, and cleaner.
Tom
next prev parent reply other threads:[~2009-07-29 21:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 3:18 Marc Khouzam
2009-07-21 6:13 ` Nick Roberts
2009-07-21 8:26 ` Hui Zhu
2009-07-21 8:29 ` Hui Zhu
2009-07-21 11:51 ` Nick Roberts
2009-07-22 6:11 ` Hui Zhu
2009-07-21 17:57 ` Michael Snyder
2009-07-21 18:37 ` Marc Khouzam
2009-07-21 18:55 ` Daniel Jacobowitz
2009-07-21 23:29 ` Nick Roberts
2009-07-22 13:38 ` Marc Khouzam
2009-07-26 5:04 ` Tom Tromey
2009-07-27 1:52 ` Nick Roberts
2009-07-27 16:17 ` Tom Tromey
2009-07-28 1:55 ` Nick Roberts
2009-07-29 21:13 ` Tom Tromey [this message]
2009-07-29 23:56 ` [PATCH] util.c + doc [was Re: [RFC] Queries and frontends] Nick Roberts
2009-07-30 0:28 ` Marc Khouzam
2009-07-30 3:13 ` Eli Zaretskii
2009-08-04 16:32 ` [PATCH] util.c + doc Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5vztcpw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox