From: Tom Tromey <tromey@redhat.com>
To: Jeroen Dobbelaere <jeroen.dobbelaere@gmail.com>
Cc: gdb@sourceware.org
Subject: Re: gdb python and 'complete'
Date: Wed, 24 Mar 2010 22:55:00 -0000 [thread overview]
Message-ID: <m3fx3pgwis.fsf@fleche.redhat.com> (raw)
In-Reply-To: <325e93671003241502u1201dabbx729c5e8a4c719680@mail.gmail.com> (Jeroen Dobbelaere's message of "Wed, 24 Mar 2010 23:02:44 +0100")
>>>>> "Jeroen" == Jeroen Dobbelaere <jeroen.dobbelaere@gmail.com> writes:
Jeroen> Would it help if we modify gdb.execute to do the redirection when we
Jeroen> call it with a 'from_tty==false' ?
Jeroen> Or do we need a new command for it ?
I think the best route is to add a new optional argument to gdb.execute,
which defaults to False and which, when True, means to return the output
as a string.
This approach is backward compatible, and also not too ugly.
I noticed, thanks to your patch, that execute_gdb_command is not using
keyword arguments. I think it should.
Jeroen> Following patch implements the redirection in gdb.execute :
If you intend to implement this, you'll need copyright assignment
paperwork on file. If you don't have this already, let me know and I
can get you started.
Tom
prev parent reply other threads:[~2010-03-24 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 15:24 Jeroen Dobbelaere
2010-03-24 15:54 ` Michel METZGER
2010-03-24 16:35 ` Jeroen Dobbelaere
2010-03-24 17:16 ` Daniel Jacobowitz
2010-03-24 17:59 ` Tom Tromey
2010-03-24 22:02 ` Jeroen Dobbelaere
2010-03-24 22:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx3pgwis.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb@sourceware.org \
--cc=jeroen.dobbelaere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox