From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4852 invoked by alias); 24 Mar 2010 22:55:37 -0000 Received: (qmail 4841 invoked by uid 22791); 24 Mar 2010 22:55:35 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Mar 2010 22:55:27 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OMtP60024477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Mar 2010 18:55:25 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2OMtOpf007635; Wed, 24 Mar 2010 18:55:24 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2OMtNZQ017152; Wed, 24 Mar 2010 18:55:24 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 867E537822D; Wed, 24 Mar 2010 16:55:23 -0600 (MDT) From: Tom Tromey To: Jeroen Dobbelaere Cc: gdb@sourceware.org Subject: Re: gdb python and 'complete' References: <325e93671003240824t3e940773ned358335b9fe1f40@mail.gmail.com> <325e93671003241502u1201dabbx729c5e8a4c719680@mail.gmail.com> Reply-To: tromey@redhat.com Date: Wed, 24 Mar 2010 22:55:00 -0000 In-Reply-To: <325e93671003241502u1201dabbx729c5e8a4c719680@mail.gmail.com> (Jeroen Dobbelaere's message of "Wed, 24 Mar 2010 23:02:44 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00200.txt.bz2 >>>>> "Jeroen" == Jeroen Dobbelaere writes: Jeroen> Would it help if we modify gdb.execute to do the redirection when we Jeroen> call it with a 'from_tty==false' ? Jeroen> Or do we need a new command for it ? I think the best route is to add a new optional argument to gdb.execute, which defaults to False and which, when True, means to return the output as a string. This approach is backward compatible, and also not too ugly. I noticed, thanks to your patch, that execute_gdb_command is not using keyword arguments. I think it should. Jeroen> Following patch implements the redirection in gdb.execute : If you intend to implement this, you'll need copyright assignment paperwork on file. If you don't have this already, let me know and I can get you started. Tom