From: Alan Modra via Gdb <gdb@sourceware.org>
To: Paul Koning <paulkoning@comcast.net>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey <tromey@adacore.com>, Sam James <sam@gentoo.org>,
binutils@sourceware.org, gdb@sourceware.org,
rostiprodev@gmail.com
Subject: Re: On automated commits
Date: Thu, 27 Jun 2024 23:13:34 +0930 [thread overview]
Message-ID: <Zn1shv8GuZr2FIW0@squeak.grove.modra.org> (raw)
In-Reply-To: <4A58E493-C4E5-410D-BD88-1B6093884320@comcast.net>
On Thu, Jun 27, 2024 at 09:23:20AM -0400, Paul Koning wrote:
>
>
> > On Jun 26, 2024, at 9:32 PM, Alan Modra <amodra@gmail.com> wrote:
> >
> > On Wed, Jun 26, 2024 at 11:17:04AM -0700, Joel Brobecker wrote:
> >>> I personally have never liked these automated commits, and I can't
> >>> recall ever using the date they provide.
> >>>
> >>> I also don't believe these dates are used here at AdaCore.
> >>>
> >>> So +1 from me for removing these.
> >>
> >> Same here.
> >>
> >> I know that some people found them useful, but I don't remember why
> >> unfortunately.
> >
> > The date is useful when looking at bug reports from people who might
> > be building from development sources.
>
> So why not have the build procedure pick up the last commit date, if building in a Git sandbox? That's easy enough to arrange. Similarly, it could pick up the identifier (SHA hash) of that last commit to make it entirely unambiguous.
I wasn't saying the way we do things now is the only way, just
explaining why the date is useful. "git show -s --oneline @{u}" or
similar would be good too, but let's make sure we report upstream
commits not local ones.
--
Alan Modra
next prev parent reply other threads:[~2024-06-27 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 23:17 Sam James via Gdb
2024-06-25 6:15 ` Jan Beulich via Gdb
2024-06-26 17:41 ` Tom Tromey via Gdb
2024-06-26 18:08 ` Fangrui Song
2024-06-26 18:17 ` Joel Brobecker via Gdb
2024-06-27 1:32 ` Alan Modra via Gdb
2024-06-27 2:46 ` H.J. Lu via Gdb
2024-06-27 3:04 ` Jiang, Haochen via Gdb
2024-06-27 3:06 ` Sam James via Gdb
2024-06-27 13:23 ` Paul Koning via Gdb
2024-06-27 13:43 ` Alan Modra via Gdb [this message]
2024-06-27 16:06 ` Jens Remus via Gdb
2024-07-02 14:59 ` John Baldwin via Gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn1shv8GuZr2FIW0@squeak.grove.modra.org \
--to=gdb@sourceware.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=paulkoning@comcast.net \
--cc=rostiprodev@gmail.com \
--cc=sam@gentoo.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox