From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Sj+nLvFsfWZmYBAAWB0awg (envelope-from ) for ; Thu, 27 Jun 2024 09:45:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=qGhqRcaa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B2A8E1E0C1; Thu, 27 Jun 2024 09:45:21 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DCB01E030 for ; Thu, 27 Jun 2024 09:45:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 19AAF38323D5 for ; Thu, 27 Jun 2024 13:45:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19AAF38323D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1719495919; bh=JYzwKg5WUT36d+4wZwY5zn8HPZzo7PO9B2PEP/T/4CM=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qGhqRcaaQaxND98eeNCbRupGnQFIeRzfybsOAo0RF22cVWdhpli+Dwasx5IomY0TT X8376BxwKTqVmNl+LmQ2EfedNmad8J7LWKM+Sb+ibC3bshLufCdoy/9tToZpnOGEfc DXZS4i7txw02U/BMjPeXXB84XR7kR1b4xYVxUWDo= Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 159523832E4C; Thu, 27 Jun 2024 13:43:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 159523832E4C ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 159523832E4C ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719495821; cv=none; b=u3lCvGVMytnOuTXGK6W2Qt8GDZ9fQMDaWnbeVlIyMoXfIMhzR8Pybh7xMQA0YrUsyCGT5mQMRMlx/g3b+kb/8IJ+iS8VWABl3F3hHpG0GdAkliNsw9jLgqa3N50qa8V6U+PhwqV9V7XPuTOHDQPs2VIxKJzK4W9xHaSw9OVPgL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719495821; c=relaxed/simple; bh=oEW/6bK0p+5x/rLBitS+ZoDWTHMvrHocjNOLtyI86vU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SwPqOLrdrOWJ+rGg/9aeA9ijAlpgNsRnsiG6VGpS8Cd7ol2kpl5F6Ar5Su7QQUr6mL8/MY8Ru6A2s5Ukd5STGky0/vDvFme04ZWo/AcVm+RhnsFG6ZsDFDGbxCLJIpTtr95HIsZC40FEukM7bsCmgyiX3qjNHDyi/YTsxpL8gPg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1fa3bdd91c1so35542305ad.2; Thu, 27 Jun 2024 06:43:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719495818; x=1720100618; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JYzwKg5WUT36d+4wZwY5zn8HPZzo7PO9B2PEP/T/4CM=; b=B3e9OneKhUYPBbsj0ozdu4J8dtKejkdOT57Hznmt2bUcq8e/yGs3HNM9XwiSqvJvsB 0z6ITgrd7BkKdJU0e1MRoP4VPkeWBYahfuZ3pvShdY3NRqeB2riLF3OSXSFhSTLD43WP uHSoZ6+rjD8hzrykJubbiZmmGeRM6W7lLZ41vgxkoaFcApuf5HsZI0R3Xz3zlVBowgfL dCpnZ2pwqRSKN6JgKvLBvGxitwsxMx0L9QFi+ArnE5Dxdiiyw098ywzAsu39FxfgS6c2 2oHBqXcif4Upp7sggr2aCP9YOWNT5WZlvzeL+aI8AH3SSNRPNa/45rO9s+y2ZwoaFbxd 5RrQ== X-Forwarded-Encrypted: i=1; AJvYcCVSgCffGJnW5MZpRwEUfwPb0viYhLWWSODNWQn0GXGcZHIc6lsmWEH+0czMFAUIp6JvsyrdedyLGGohPsB67YmVtkP8H727zbok4DJattoJenqOyJmF74zeXar/ X-Gm-Message-State: AOJu0Yw0f0PIGTMlGK83i+l2PvTdjLXenOJ1UI3eA8Bts6W8VxslALSC eaXBBp0WpWRQEc4T9NOitp143gHuksM7IrzM8NmZL1IUeYYtqTq8 X-Google-Smtp-Source: AGHT+IE9p55VTtZuGhNy/INq97+bV8ivq5vA8ldUP1v8dKqwubF4FPEsQVx0v49J9ag0dqL0hGN/eQ== X-Received: by 2002:a17:902:8bca:b0:1fa:2b89:f549 with SMTP id d9443c01a7336-1fa2b89f7c0mr112031295ad.10.1719495817887; Thu, 27 Jun 2024 06:43:37 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:4d08:cebd:d73f:b794]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac97914bsm13253225ad.121.2024.06.27.06.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 06:43:37 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id E15A51140183; Thu, 27 Jun 2024 23:13:34 +0930 (ACST) Date: Thu, 27 Jun 2024 23:13:34 +0930 To: Paul Koning Cc: Joel Brobecker , Tom Tromey , Sam James , binutils@sourceware.org, gdb@sourceware.org, rostiprodev@gmail.com Subject: Re: On automated commits Message-ID: References: <87sex2orqp.fsf@gentoo.org> <87bk3nsisx.fsf@tromey.com> <4A58E493-C4E5-410D-BD88-1B6093884320@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A58E493-C4E5-410D-BD88-1B6093884320@comcast.net> X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Modra via Gdb Reply-To: Alan Modra Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Thu, Jun 27, 2024 at 09:23:20AM -0400, Paul Koning wrote: > > > > On Jun 26, 2024, at 9:32 PM, Alan Modra wrote: > > > > On Wed, Jun 26, 2024 at 11:17:04AM -0700, Joel Brobecker wrote: > >>> I personally have never liked these automated commits, and I can't > >>> recall ever using the date they provide. > >>> > >>> I also don't believe these dates are used here at AdaCore. > >>> > >>> So +1 from me for removing these. > >> > >> Same here. > >> > >> I know that some people found them useful, but I don't remember why > >> unfortunately. > > > > The date is useful when looking at bug reports from people who might > > be building from development sources. > > So why not have the build procedure pick up the last commit date, if building in a Git sandbox? That's easy enough to arrange. Similarly, it could pick up the identifier (SHA hash) of that last commit to make it entirely unambiguous. I wasn't saying the way we do things now is the only way, just explaining why the date is useful. "git show -s --oneline @{u}" or similar would be good too, but let's make sure we report upstream commits not local ones. -- Alan Modra