Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Schimpe, Christina via Gdb" <gdb@sourceware.org>
To: Guinevere Larsen <blarsen@redhat.com>,
	"gdb@sourceware.org" <gdb@sourceware.org>
Subject: RE: Shadow stack backtrace command name
Date: Wed, 20 Dec 2023 15:11:59 +0000	[thread overview]
Message-ID: <SN7PR11MB7638CC69F1F2D3CAEB731A4FF996A@SN7PR11MB7638.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2bae9689-e638-262d-ad5f-6ae38c900ce0@redhat.com>

Thanks a lot for you review. Please see my feedback to your comments below.

> My first thought about this output is that I don't think most users are interested in
> what goes on below the main function. I think it would be nice to suppress that
> output (I personally would like that to be the default, but as long as its an option
> I'm happy).

For the normal bt command there are the options -past-main and -past-entry. We
could consider adding them to the new command for shadow stack bt as well.
However, for the shadow-stack it's a bit different as the stack size depends on the
enablement of shstk.

> As for names, I don't see a need for starting with "info". In my opinion, just calling
> it "shadow-stack backtrace" is fine. Users could then set their own abbreviations,
> like shstk or cet if they like.

One reason for me to have the "info" is to make the command easier to find. If the 
user would type "help info" the command would be listed  (among others).

Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2023-12-20 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  9:42 Schimpe, Christina via Gdb
2023-12-20 10:59 ` Guinevere Larsen via Gdb
2023-12-20 15:11   ` Schimpe, Christina via Gdb [this message]
2023-12-20 11:38 ` Luis Machado via Gdb
2023-12-20 15:35   ` Schimpe, Christina via Gdb
2023-12-20 15:57     ` Luis Machado via Gdb
2023-12-21  4:35       ` Thiago Jung Bauermann via Gdb
2023-12-21 22:26 ` Shadow stack command to host related subcommands (was Re: Shadow stack backtrace command name) Thiago Jung Bauermann via Gdb
2024-01-09  8:34   ` Schimpe, Christina via Gdb
2023-12-23 18:22 ` Shadow stack backtrace command name Tom Tromey
2023-12-28 22:34   ` Thiago Jung Bauermann via Gdb
2024-01-09 10:21     ` Schimpe, Christina via Gdb
2024-07-05 18:16       ` Florian Weimer via Gdb
2024-07-09 14:50         ` Schimpe, Christina via Gdb
2024-07-09 15:16           ` Florian Weimer via Gdb
2024-07-10  9:07             ` Schimpe, Christina via Gdb
2024-07-10 10:05               ` Florian Weimer via Gdb
2024-07-10 11:35                 ` Schimpe, Christina via Gdb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR11MB7638CC69F1F2D3CAEB731A4FF996A@SN7PR11MB7638.namprd11.prod.outlook.com \
    --to=gdb@sourceware.org \
    --cc=blarsen@redhat.com \
    --cc=christina.schimpe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox