enum enable

enum enable

[Eli Zaretskii]

breakpoint.h declares `enum enable'.  This gets in the way with some of 
the DJGPP headers, because there's a library function by that name (which 
enables interrupts).

Is it possible to rename the enum to something less general, such as 
`enum bp_enable'?

Re: enum enable

[Elena Zannoni]

Eli Zaretskii writes:
 > breakpoint.h declares `enum enable'.  This gets in the way with some of 
 > the DJGPP headers, because there's a library function by that name (which 
 > enables interrupts).
 > 
 > Is it possible to rename the enum to something less general, such as 
 > `enum bp_enable'?

I say, go for it. There is another 'enum enable' in memattr.c. This
one too will need to get a more specific name.

Elena

Re: enum enable

[J.T. Conklin]

>>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>> breakpoint.h declares `enum enable'.  This gets in the way with some of 
>> the DJGPP headers, because there's a library function by that name (which 
>> enables interrupts).
>> 
>> Is it possible to rename the enum to something less general, such as 
>> `enum bp_enable'?

Elena> I say, go for it. There is another 'enum enable' in memattr.c. This
Elena> one too will need to get a more specific name.

Note that I stole that from tracepoint.c, so you'll want to look there
as well.

        -jtc

-- 
J.T. Conklin
RedBack Networks

Re: enum enable

[Andrew Cagney]

> breakpoint.h declares `enum enable'.  This gets in the way with some of 
> the DJGPP headers, because there's a library function by that name (which 
> enables interrupts).


I hit this when trying to fix some of the include header problems 
several years back.  Neadless to say I ducked the issue.


> Is it possible to rename the enum to something less general, such as 
> `enum bp_enable'?


My preference is for memattr.c to use ``int enabled_p'' and for 
breakpoint.h to use something like ``enum bp_state { bp_enabled, ...''.

	Andrew

Re: enum enable

[Elena Zannoni]

Andrew Cagney writes:
 > > breakpoint.h declares `enum enable'.  This gets in the way with some of 
 > > the DJGPP headers, because there's a library function by that name (which 
 > > enables interrupts).
 > 
 > 
 > I hit this when trying to fix some of the include header problems 
 > several years back.  Neadless to say I ducked the issue.
 > 
 > 
 > > Is it possible to rename the enum to something less general, such as 
 > > `enum bp_enable'?
 > 
 > 
 > My preference is for memattr.c to use ``int enabled_p'' and for 
 > breakpoint.h to use something like ``enum bp_state { bp_enabled, ...''.
 > 
 > 	Andrew


Hmm, there is also this bit in tracepoint.h:

#if !defined (BREAKPOINT_H)
enum enable
  {
    disabled, enabled
  };
#endif


Elena

Re: enum enable

[Michael Snyder]

Eli Zaretskii wrote:
> 
> breakpoint.h declares `enum enable'.  This gets in the way with some of
> the DJGPP headers, because there's a library function by that name (which
> enables interrupts).
> 
> Is it possible to rename the enum to something less general, such as
> `enum bp_enable'?

It's been discussed before, and I think the consensus
was that it is a good idea.  I'm certainly open to it.

Re: enum enable

[Eli Zaretskii]

> Date: Thu, 12 Jul 2001 17:32:53 -0700
> From: Michael Snyder <msnyder@redhat.com>
> 
> Eli Zaretskii wrote:
> > 
> > breakpoint.h declares `enum enable'.  This gets in the way with some of
> > the DJGPP headers, because there's a library function by that name (which
> > enables interrupts).
> > 
> > Is it possible to rename the enum to something less general, such as
> > `enum bp_enable'?
> 
> It's been discussed before, and I think the consensus
> was that it is a good idea.  I'm certainly open to it.

Thanks, I will submit a patch soon, hopefully today or tomorrow.