Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Berlin <dan@cgsoftware.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Benjamin Kosnik <bkoz@redhat.com>,
	Eli Zaretskii <eliz@is.elta.co.il>, <jason@redhat.com>,
	<libstdc++@gcc.gnu.org>, <gdb@sources.redhat.com>
Subject: Re: c++ debugging hosed
Date: Mon, 26 Nov 2001 16:43:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.33.0111261942360.20651-100000@www.cgsoftware.com> (raw)
In-Reply-To: <20011126183836.A9099@nevyn.them.org>

On Mon, 26 Nov 2001, Daniel Jacobowitz wrote:

> On Sun, Nov 25, 2001 at 03:29:08PM -0500, Daniel Berlin wrote:
> >
> >
> > On Sun, 25 Nov 2001, Benjamin Kosnik wrote:
> >
> > >
> > > > No, it's relevant to STABS, too.
> > > > It's due to not properly searching virtual baseclasses.
> > > > I might still have the changes to do that somewhere, if someone wants
> > > > them.
> > >
> > > This has been broken for some time now. I'd appreciate it if it got
> > > fixed, so that C++ could be debugged properly.
> > I'm sure a lot of people would.
> > Unfortunately, it appears I don't have the code i had worked up to
> > abstract out the base class offset finding anymore.
> > What's happening is that GDB wants to know the baseclass offset, and
> > the routine it uses is tuned to either gnu-v2 or hp aCC (it checks
> > for something only hp's debug readers fill in, and if it doesn't find
> > it, it assumes gnu-v2), and the gnu-v2 code either returns the wrong
> > value (weird errors occur), or -1, which gives you "virtual baseclass
> > botch"/attempts to deref int values as pointers.
> >
> > baseclass_offset needs to be abstracted into the cp abi model, and all
> > existing uses need to use it.
>
> Could you clarify what symptom this fix you're discussing is supposed
> to solve?
Not being able to print subobjects, etc.
>   I thought it was the one I was working on, but
> baseclass_offset actually does nothing ABI specific at all.
This would be incorrect for virtual base classes
Look at it again.
Also notice we call find_rt_base_offset for the HP ABI.
The reason is that baseclass offsets are *always* abi specific.


>
> Meanwhile the problem that was most annoying me wasn't even covered by
> the testsuite.  Patch and tests coming up in the next hour.
>
> --
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
>


WARNING: multiple messages have this Message-ID
From: Daniel Berlin <dan@cgsoftware.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Benjamin Kosnik <bkoz@redhat.com>,
	Eli Zaretskii <eliz@is.elta.co.il>, <jason@redhat.com>,
	<libstdc++@gcc.gnu.org>, <gdb@sources.redhat.com>
Subject: Re: c++ debugging hosed
Date: Thu, 15 Nov 2001 08:48:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.33.0111261942360.20651-100000@www.cgsoftware.com> (raw)
Message-ID: <20011115084800.21Ul1VeIsclds2UwVucoMEV1SdVchQnzJl6JOzBJu5I@z> (raw)
In-Reply-To: <20011126183836.A9099@nevyn.them.org>



On Mon, 26 Nov 2001, Daniel Jacobowitz wrote:

> On Sun, Nov 25, 2001 at 03:29:08PM -0500, Daniel Berlin wrote:
> >
> >
> > On Sun, 25 Nov 2001, Benjamin Kosnik wrote:
> >
> > >
> > > > No, it's relevant to STABS, too.
> > > > It's due to not properly searching virtual baseclasses.
> > > > I might still have the changes to do that somewhere, if someone wants
> > > > them.
> > >
> > > This has been broken for some time now. I'd appreciate it if it got
> > > fixed, so that C++ could be debugged properly.
> > I'm sure a lot of people would.
> > Unfortunately, it appears I don't have the code i had worked up to
> > abstract out the base class offset finding anymore.
> > What's happening is that GDB wants to know the baseclass offset, and
> > the routine it uses is tuned to either gnu-v2 or hp aCC (it checks
> > for something only hp's debug readers fill in, and if it doesn't find
> > it, it assumes gnu-v2), and the gnu-v2 code either returns the wrong
> > value (weird errors occur), or -1, which gives you "virtual baseclass
> > botch"/attempts to deref int values as pointers.
> >
> > baseclass_offset needs to be abstracted into the cp abi model, and all
> > existing uses need to use it.
>
> Could you clarify what symptom this fix you're discussing is supposed
> to solve?
Not being able to print subobjects, etc.
>   I thought it was the one I was working on, but
> baseclass_offset actually does nothing ABI specific at all.
This would be incorrect for virtual base classes
Look at it again.
Also notice we call find_rt_base_offset for the HP ABI.
The reason is that baseclass offsets are *always* abi specific.


>
> Meanwhile the problem that was most annoying me wasn't even covered by
> the testsuite.  Patch and tests coming up in the next hour.
>
> --
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
>


  parent reply	other threads:[~2001-11-26 16:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200110291812.f9TICtQ10130@constant.com>
2001-11-03  1:50 ` Jason Merrill
2001-11-03  7:59   ` Benjamin Kosnik
2001-11-03 10:52     ` Benjamin Kosnik
2001-11-12  8:27   ` Eli Zaretskii
2001-11-12 11:29     ` Daniel Berlin
2001-11-13 10:06       ` Benjamin Kosnik
2001-11-13 10:07         ` Daniel Berlin
2001-11-13 13:18           ` Benjamin Kosnik
2001-11-25 22:56             ` Benjamin Kosnik
2001-11-26 15:38           ` Daniel Jacobowitz
2001-11-14 20:13             ` Daniel Jacobowitz
2001-11-15  8:55             ` Daniel Berlin
2001-11-15 13:10               ` Daniel Jacobowitz
2001-11-26 17:19                 ` Daniel Jacobowitz
2001-11-26 16:53               ` Daniel Berlin
2001-11-26 16:43             ` Daniel Berlin [this message]
2001-11-15  8:48               ` Daniel Berlin
2001-11-26 16:53               ` Daniel Jacobowitz
2001-11-15  9:57                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0111261942360.20651-100000@www.cgsoftware.com \
    --to=dan@cgsoftware.com \
    --cc=bkoz@redhat.com \
    --cc=drow@mvista.com \
    --cc=eliz@is.elta.co.il \
    --cc=gdb@sources.redhat.com \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox