Some testpatterns seems have problems

Some testpatterns seems have problems

[qinwei]

Hi all,

When i was testing score gdb, i found these testpatterns have problems;

1, long_long.exp,
when using p/a, if the address has instructions, gdb will print out the 
offset,

p/a *(char *)c
$32 = 0x1 <_start+1>
(gdb) FAIL: gdb.base/long_long.exp: p/a *(char *)c

p/a *(short *)s
$40 = 0x123 <frame_dummy+55>
(gdb) FAIL: gdb.base/long_long.exp: p/a *(short *)s

so,
gdb_test_char "p/a *(char *)c" "0x1"
gdb_test_short "p/a *(short *)s" "" "0x123" ""
should be 
gdb_test_char "p/a *(char *)c" "0x1.*"
gdb_test_short "p/a *(short *)s" "" "0x123.*" ""

2, mi-basics.exp, mi2-basics.exp:
gdb will print out the full path.

202-environment-directory ../../../gdb-6.6/gdb/testsuite/gdb.mi
202^done,source-path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite/gdb.mi
:$cdir:$cwd"
(gdb) 
FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation

203-environment-directory
203^done,source-path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite/gdb.mi
:$cdir:$cwd"
(gdb) 
FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation

208-environment-path ../../../gdb-6.6/gdb/testsuite 
/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite
208^done,path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite:/home/qinwei/
gnu/GJ275_CVS/code/build/gdb/testsuite:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin:/home/qinw
ei/gcc/bin:/home/qinwei/usr/bin:/home/qinwei/usr/lib/gcc-lib/unsp-sgi-linux/sgicc-1.0:/home/qinwei/gnu/install-
score-elf/bin:/home/qinwei/bin:/home/qinwei/daVinci_V2.1"
(gdb) 
FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation

Best regards,
Qinwei
Mail  qinwei@sunnorth.com.cn
Phone +86-010-62981668-2708
Fax   +86-010-62985972

Re: Some testpatterns seems have problems

[Jim Blandy]

Hi, Qinwei.  (I haven't forgotten about your S+Core patch --- I'll
give it a new review in a bit.)

qinwei<qinwei@sunnorth.com.cn> writes:
> 1, long_long.exp,
> when using p/a, if the address has instructions, gdb will print out the 
> offset,
>
> p/a *(char *)c
> $32 = 0x1 <_start+1>
> (gdb) FAIL: gdb.base/long_long.exp: p/a *(char *)c
>
> p/a *(short *)s
> $40 = 0x123 <frame_dummy+55>
> (gdb) FAIL: gdb.base/long_long.exp: p/a *(short *)s
>
> so,
> gdb_test_char "p/a *(char *)c" "0x1"
> gdb_test_short "p/a *(short *)s" "" "0x123" ""
> should be 
> gdb_test_char "p/a *(char *)c" "0x1.*"
> gdb_test_short "p/a *(short *)s" "" "0x123.*" ""

Yes, this is right.  Although I would prefer if you used a tighter
pattern that didn't permit arbitrary garbage: say, "0x123( <.*>)?".

These are definitely the sorts of changes which you should post as
patches.  Describing the fix in English, as you've done, makes it
harder to review and test your patch.  Generate diffs from the top of
the source tree --- the directory containing 'gdb', 'bfd', 'sim',
etc.) with 'cvs diff' (or 'cvs diff -N', if you have added files).
Don't include the ChangeLog in the diff, because such patches are very
likely to conflict needlessly; just put the entry above the patch.
And as I've said, don't include diffs to generated files like
'configure' or 'aclocal.m4'.


> 2, mi-basics.exp, mi2-basics.exp:
> gdb will print out the full path.
>
> 202-environment-directory ../../../gdb-6.6/gdb/testsuite/gdb.mi
> 202^done,source-path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite/gdb.mi
> :$cdir:$cwd"
> (gdb) 
> FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
>
> 203-environment-directory
> 203^done,source-path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite/gdb.mi
> :$cdir:$cwd"
> (gdb) 
> FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation
>
> 208-environment-path ../../../gdb-6.6/gdb/testsuite 
> /home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite
> 208^done,path="/home/qinwei/gnu/GJ275_CVS/code/build/gdb/testsuite/../../../gdb-6.6/gdb/testsuite:/home/qinwei/
> gnu/GJ275_CVS/code/build/gdb/testsuite:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin:/home/qinw
> ei/gcc/bin:/home/qinwei/usr/bin:/home/qinwei/usr/lib/gcc-lib/unsp-sgi-linux/sgicc-1.0:/home/qinwei/gnu/install-
> score-elf/bin:/home/qinwei/bin:/home/qinwei/daVinci_V2.1"
> (gdb) 
> FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation

Yes, I see these failures too; I think they've been present for a
while.  Do you have a patch for this?

Re: Some testpatterns seems have problems

[Daniel Jacobowitz]

On Thu, Dec 14, 2006 at 11:51:33AM -0800, Jim Blandy wrote:
> Yes, I see these failures too; I think they've been present for a
> while.  Do you have a patch for this?

IIRC, these tests pass if you use /full/path/to/configure and fail
otherwise; I never worked out a good way to check the whole path from
the testsuite.

-- 
Daniel Jacobowitz
CodeSourcery