From: Doug Evans <xdje42@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: gdb@sourceware.org
Subject: Re: [PATCH] guile: Type-check the argument to 'history-append!'
Date: Thu, 05 Jun 2014 16:35:00 -0000 [thread overview]
Message-ID: <CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A@mail.gmail.com> (raw)
In-Reply-To: <87vbsfv7t9.fsf@gnu.org>
On Thu, Jun 5, 2014 at 5:50 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> The patch below add a missing type check in ‘history-append!’ (I’m guilty.)
>
> OK to push?
>
> Ludo’.
>
> gdb/
> 2014-06-05 Ludovic Courtès <ludo@gnu.org>
>
> * guile/scm-value.c (gdbscm_history_append_x): Use
> 'vlscm_get_value_smob_arg_unsafe' instead of
> 'vlscm_scm_to_value'.
>
> gdb/testsuite/
> 2014-06-05 Ludovic Courtès <ludo@gnu.org>
>
> * gdb.guile/scm-value.exp (test_value_in_inferior): Add test
> "history-append! type error".
LGTM.
next prev parent reply other threads:[~2014-06-05 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 12:51 Ludovic Courtès
2014-06-05 16:35 ` Doug Evans [this message]
2014-06-05 22:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A@mail.gmail.com' \
--to=xdje42@gmail.com \
--cc=gdb@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox