From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-43386-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 4618 invoked by alias); 5 Jun 2014 16:35:13 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 4606 invoked by uid 89); 5 Jun 2014 16:35:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f180.google.com
Received: from mail-yk0-f180.google.com (HELO mail-yk0-f180.google.com) (209.85.160.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Jun 2014 16:35:10 +0000
Received: by mail-yk0-f180.google.com with SMTP id q9so1020419ykb.25        for <gdb@sourceware.org>; Thu, 05 Jun 2014 09:35:08 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.236.152.2 with SMTP id c2mr82806566yhk.25.1401986108806; Thu, 05 Jun 2014 09:35:08 -0700 (PDT)
Received: by 10.170.150.70 with HTTP; Thu, 5 Jun 2014 09:35:08 -0700 (PDT)
In-Reply-To: <87vbsfv7t9.fsf@gnu.org>
References: <87vbsfv7t9.fsf@gnu.org>
Date: Thu, 05 Jun 2014 16:35:00 -0000
Message-ID: <CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A@mail.gmail.com>
Subject: Re: [PATCH] guile: Type-check the argument to 'history-append!'
From: Doug Evans <xdje42@gmail.com>
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: gdb@sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-06/txt/msg00021.txt.bz2

On Thu, Jun 5, 2014 at 5:50 AM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
> The patch below add a missing type check in =E2=80=98history-append!=E2=
=80=99 (I=E2=80=99m guilty.)
>
> OK to push?
>
> Ludo=E2=80=99.
>
> gdb/
> 2014-06-05  Ludovic Court=C3=A8s  <ludo@gnu.org>
>
>         * guile/scm-value.c (gdbscm_history_append_x): Use
>         'vlscm_get_value_smob_arg_unsafe' instead of
>         'vlscm_scm_to_value'.
>
> gdb/testsuite/
> 2014-06-05  Ludovic Court=C3=A8s  <ludo@gnu.org>
>
>         * gdb.guile/scm-value.exp (test_value_in_inferior): Add test
>         "history-append! type error".

LGTM.