Re: gdb ignoring vCont supported commands

[Bill Morgan <arthurwilliammorgan@gmail.com>]

On Fri, Oct 19, 2018 at 8:35 AM Pedro Alves <palves@redhat.com> wrote:

> On 10/18/2018 02:42 PM, Bill Morgan wrote:
> > On Tue, Oct 9, 2018 at 4:12 PM Pedro Alves <palves@redhat.com> wrote:
> >
> >> On 10/09/2018 09:29 PM, Bill Morgan wrote:
> >>>
> >>> So it is now recognizing the vContSupported, but it is still sending
> >>> vCont;s
> >>>
> >>
> >> Argh, I forgot that this only really works on ARM GNU/Linux.
> >> What is your target?
> >>
> >> We're missing the small infrastructure change in GDB
> >> mentioned in the discussion I linked before.
> >>
> >
> > I couldn't get the change on the other thread to work,
>
> What change do you mean?
>
> The change you posted here:
https://sourceware.org/ml/gdb-patches/2018-09/msg00312.html

"The only think missing then I think is moving the only call to

target_can_do_single_step out of the arm-linux-tdep.c file:

 static std::vector<CORE_ADDR>
 arm_linux_software_single_step (struct regcache *regcache)
 {
   struct gdbarch *gdbarch = regcache->arch ();
   struct arm_get_next_pcs next_pcs_ctx;

   /* If the target does have hardware single step, GDB doesn't have
      to bother software single step.  */
   if (target_can_do_single_step () == 1)
     return {};


into somewhere more generic, around infrun.c:maybe_software_singlestep."