From: Ian Lance Taylor <iant@google.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Binutils <binutils@sourceware.org>, gdb <gdb@sourceware.org>
Subject: Re: [patch libiberty's include]: Fixes PR 39064 and partial PR 54620
Date: Wed, 30 Jan 2013 14:31:00 -0000 [thread overview]
Message-ID: <CAKOQZ8xVJecJKHEucOjcptHGNDt_ptx_t=OW9RrUT0F8qLM=zg@mail.gmail.com> (raw)
In-Reply-To: <CAEwic4b+9OehgfoEy3WCZbpFqpzqSXxewAc8rCL1HRf=OsGsMQ@mail.gmail.com>
On Wed, Jan 30, 2013 at 2:53 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>
> this patch fixes for targets with sys/types.h the issue that wrong
> assumptions about pointer-sizes are used.
> Instead it uses uintptr_t/intptr_t.
>
> ChangeLog /include
>
> 2013-01-30 Kai Tietz <ktietz@redhat.com>
>
> PR other/54620
> PR target/39064
> * md5.h: Include sys/types.h if HAVE_SYS_TYPES_H
> is defined.
> * sha1.h: Likewise.
>
> Tested for x86_64-unknown-linux-gnu, x86_64-w64-mingw32, and
> i686-w64-mingw32. Ok for apply?
>
> Regards,
> Kai
>
> Index: md5.h
> ===================================================================
> --- md5.h (Revision 195288)
> +++ md5.h (Arbeitskopie)
> @@ -36,7 +36,7 @@
> the resulting executable. Locally running cross-compiled executables
> is usually not possible. */
>
> -#ifdef _LIBC
> +#if defined (_LIBC) || defined (HAVE_SYS_TYPES_H)
> # include <sys/types.h>
> typedef u_int32_t md5_uint32;
> typedef uintptr_t md5_uintptr;
> Index: sha1.h
> ===================================================================
> --- sha1.h (Revision 195288)
> +++ sha1.h (Arbeitskopie)
> @@ -35,7 +35,7 @@
> the resulting executable. Locally running cross-compiled executables
> is usually not possible. */
>
> -#ifdef _LIBC
> +#if defined (_LIBC) || defined (HAVE_SYS_TYPES_H)
> # include <sys/types.h>
> typedef u_int32_t sha1_uint32;
> typedef uintptr_t sha1_uintptr;
This code is intended to be highly portable. I don't have a problem
with uintptr_t, but I'm not certain that <sys/types.h> on all systems
defines u_int32_t.
Ian
next prev parent reply other threads:[~2013-01-30 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 10:53 Kai Tietz
2013-01-30 14:31 ` Ian Lance Taylor [this message]
2013-01-30 14:48 ` Kai Tietz
2013-01-30 14:56 ` Rainer Orth
2013-01-30 15:03 ` Kai Tietz
2013-01-30 15:44 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8xVJecJKHEucOjcptHGNDt_ptx_t=OW9RrUT0F8qLM=zg@mail.gmail.com' \
--to=iant@google.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox