From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29200 invoked by alias); 30 Jan 2013 14:31:45 -0000 Received: (qmail 29181 invoked by uid 22791); 30 Jan 2013 14:31:44 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f49.google.com (HELO mail-oa0-f49.google.com) (209.85.219.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jan 2013 14:31:34 +0000 Received: by mail-oa0-f49.google.com with SMTP id j6so1744066oag.36 for ; Wed, 30 Jan 2013 06:31:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=n2QdishxQEWRNlv56p9h1+JwzrjmSiLzCS4znzSSCEE=; b=P8GlJLK5SmkdMj6gvzqI6WYiIlZSewuuXgcqGqCnHd/uzmuTI9idXCRAcGdemfZdht 8sFmwA88Y5oL9RD82Ps3/PolAjJ8IxyKK74CUvUfNK9CRfInh0Uc4gMmUCsgcEYiZbcV lnKVkhSLLkhDWgvGDxUT40/BcZiAvvnXTkJ7faXa5HO8yICPvslNV7vQk3zAINPGtL9K ha4sqKPAyhRPVH5eqJ4vMM0E6Oqmw4wiQoO2BFn3pCOJgwz0m7RktM47mH8p4lbvVPx4 rE6lWSB077LqXL7FMXPkVAAzCbTj3z/JwsW/NTjbIljpm+Jf2Q29204K5di4yGhzpeHj YQcw== MIME-Version: 1.0 X-Received: by 10.182.159.98 with SMTP id xb2mr3822228obb.35.1359556294211; Wed, 30 Jan 2013 06:31:34 -0800 (PST) Received: by 10.182.23.39 with HTTP; Wed, 30 Jan 2013 06:31:34 -0800 (PST) In-Reply-To: References: Date: Wed, 30 Jan 2013 14:31:00 -0000 Message-ID: Subject: Re: [patch libiberty's include]: Fixes PR 39064 and partial PR 54620 From: Ian Lance Taylor To: Kai Tietz Cc: GCC Patches , Binutils , gdb Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnS6j39GPtgH6xJ2zGbgeSk09jKeAsaVbyDTNMJKoXlvY5VO0wMyZuDeRT9IsD0guaRyuKpXAzCu5zhTYXPnlVoaogMQRYz/zrGHLRnkIb9ERKN7SgjAy9G5e2kPhVuv10tZWgBr1aY73WLg7jb7WDvB/gGheAvT/uhtTNGCckDn+nd7EkmMWuEbm7ANOX92sOhO7yU Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00084.txt.bz2 On Wed, Jan 30, 2013 at 2:53 AM, Kai Tietz wrote: > > this patch fixes for targets with sys/types.h the issue that wrong > assumptions about pointer-sizes are used. > Instead it uses uintptr_t/intptr_t. > > ChangeLog /include > > 2013-01-30 Kai Tietz > > PR other/54620 > PR target/39064 > * md5.h: Include sys/types.h if HAVE_SYS_TYPES_H > is defined. > * sha1.h: Likewise. > > Tested for x86_64-unknown-linux-gnu, x86_64-w64-mingw32, and > i686-w64-mingw32. Ok for apply? > > Regards, > Kai > > Index: md5.h > =================================================================== > --- md5.h (Revision 195288) > +++ md5.h (Arbeitskopie) > @@ -36,7 +36,7 @@ > the resulting executable. Locally running cross-compiled executables > is usually not possible. */ > > -#ifdef _LIBC > +#if defined (_LIBC) || defined (HAVE_SYS_TYPES_H) > # include > typedef u_int32_t md5_uint32; > typedef uintptr_t md5_uintptr; > Index: sha1.h > =================================================================== > --- sha1.h (Revision 195288) > +++ sha1.h (Arbeitskopie) > @@ -35,7 +35,7 @@ > the resulting executable. Locally running cross-compiled executables > is usually not possible. */ > > -#ifdef _LIBC > +#if defined (_LIBC) || defined (HAVE_SYS_TYPES_H) > # include > typedef u_int32_t sha1_uint32; > typedef uintptr_t sha1_uintptr; This code is intended to be highly portable. I don't have a problem with uintptr_t, but I'm not certain that on all systems defines u_int32_t. Ian