From: Jim Wilson <jimw@sifive.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb@sourceware.org
Subject: Re: RISC-V: decr_pc_after_break causing problems
Date: Mon, 16 Jul 2018 22:09:00 -0000 [thread overview]
Message-ID: <CAFyWVaYH9+8hG5KkLrJtLbFYZkFw0iHctdeAupkwdpBGS4a5Kw@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVaav9FK4-TTA6TprkEfds2oJKfX5B1GfiMUdwpZXY6ZLAw@mail.gmail.com>
On Wed, Jul 11, 2018 at 11:20 AM, Jim Wilson <jimw@sifive.com> wrote:
> On Wed, Jul 11, 2018 at 10:46 AM, Andrew Burgess
> <andrew.burgess@embecosm.com> wrote:
>> * Jim Wilson <jimw@sifive.com> [2018-06-25 19:54:14 -0700]:
>>
>>> The RISC-V port in the riscv-tdep.c file has
>>> set_gdbarch_decr_pc_after_break (gdbarch, (has_compressed_isa ? 2 : 4));
Since everyone seems to agree that gdb should not be modifying pc if
it is unnecessary, I went ahead and submitted the linux kernel patch
side of this.
https://patchwork.kernel.org/patch/10524925/
We now need a gdb change to remove the code that calls
set_gdbarch_decr_pc_after_break, the has_compressed_isa local, and the
now incorrect comment in riscv_has_feature. I can submit a patch for
that.
Jim
prev parent reply other threads:[~2018-07-16 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 2:54 Jim Wilson
2018-06-26 19:15 ` Tim Newsome
2018-07-04 0:17 ` Jim Wilson
2018-07-04 0:35 ` Palmer Dabbelt
2018-07-05 22:54 ` John Baldwin
2018-07-11 14:52 ` Andrew Burgess
2018-07-11 17:47 ` Andrew Burgess
2018-07-11 18:20 ` Jim Wilson
2018-07-16 22:09 ` Jim Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaYH9+8hG5KkLrJtLbFYZkFw0iHctdeAupkwdpBGS4a5Kw@mail.gmail.com \
--to=jimw@sifive.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox