From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-46520-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 65157 invoked by alias); 16 Jul 2018 22:09:14 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 65139 invoked by uid 89); 16 Jul 2018 22:09:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-wm0-f66.google.com
Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 22:09:12 +0000
Received: by mail-wm0-f66.google.com with SMTP id y22-v6so2835701wma.0        for <gdb@sourceware.org>; Mon, 16 Jul 2018 15:09:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=sifive.com; s=google;        h=mime-version:in-reply-to:references:from:date:message-id:subject:to         :cc;        bh=mXba486awQ3GF9FGECPmMsesln06r+jXyO7lZnAf4/s=;        b=k57rkYtu2WbJ+PHvltVcU3WlsvHdjbOv+NEbvdsnInI5DZ2v0UYRlD3CNe6yGNWMax         apxCFk/qVd0NaqSZjeD2QkX9250G3Rdc9Dx9Z1RHuYs16ereLZSs4YaClZNix41DMwJo         5rDuxDgAvHrF+SNrymI+zQ2BUUDPa+9KDK1Jy5sqjTlmsnZ2cP+pdAIni9MltsXaCRm4         zLlWVc35WQBM02aM7PRnRyRr7F/AY81nxq0FZt/9vzSY3TN7BY3YT8XMRNUxzZ7P9v5i         56POst9Z9O2604A/sMUtOrqCEIEVmJXveSnTDjC1qX5MxhfScdK3k0y+oo04HV05WoF5         KoUw==
MIME-Version: 1.0
Received: by 2002:adf:e44b:0:0:0:0:0 with HTTP; Mon, 16 Jul 2018 15:09:09 -0700 (PDT)
In-Reply-To: <CAFyWVaav9FK4-TTA6TprkEfds2oJKfX5B1GfiMUdwpZXY6ZLAw@mail.gmail.com>
References: <CAFyWVaYoF8LmH=RGEZTrMWqaYF0i3GERZG-B_rDxtTt2LQs9gw@mail.gmail.com> <20180711174659.GA6398@embecosm.com> <CAFyWVaav9FK4-TTA6TprkEfds2oJKfX5B1GfiMUdwpZXY6ZLAw@mail.gmail.com>
From: Jim Wilson <jimw@sifive.com>
Date: Mon, 16 Jul 2018 22:09:00 -0000
Message-ID: <CAFyWVaYH9+8hG5KkLrJtLbFYZkFw0iHctdeAupkwdpBGS4a5Kw@mail.gmail.com>
Subject: Re: RISC-V: decr_pc_after_break causing problems
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-07/txt/msg00032.txt.bz2

On Wed, Jul 11, 2018 at 11:20 AM, Jim Wilson <jimw@sifive.com> wrote:
> On Wed, Jul 11, 2018 at 10:46 AM, Andrew Burgess
> <andrew.burgess@embecosm.com> wrote:
>> * Jim Wilson <jimw@sifive.com> [2018-06-25 19:54:14 -0700]:
>>
>>> The RISC-V port in the riscv-tdep.c file has
>>>   set_gdbarch_decr_pc_after_break (gdbarch, (has_compressed_isa ? 2 : 4));

Since everyone seems to agree that gdb should not be modifying pc if
it is unnecessary, I went ahead and submitted the linux kernel patch
side of this.
https://patchwork.kernel.org/patch/10524925/

We now need a gdb change to remove the code that calls
set_gdbarch_decr_pc_after_break, the has_compressed_isa local, and the
now incorrect comment in riscv_has_feature.  I can submit a patch for
that.

Jim