Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <ktietz70@googlemail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb@sourceware.org
Subject: Re: [patch gdb]: Fix some DOS-path related issues in gdb
Date: Thu, 03 Mar 2011 12:50:00 -0000	[thread overview]
Message-ID: <AANLkTin+0ozrOsXDQX7AgzqwokNCF3-P8443kLM2HrnT@mail.gmail.com> (raw)
In-Reply-To: <201103031214.p23CEj4Z010743@glazunov.sibelius.xs4all.nl>

2011/3/3 Mark Kettenis <mark.kettenis@xs4all.nl>:
>> Date: Thu, 3 Mar 2011 13:02:11 +0100
>> From: Kai Tietz <ktietz70@googlemail.com>
>>
>> Hello,
>>
>> This patch fixes some issues related to DOS file-system filenames and
>> paths. I am not sure, if I
>> hit all places, nevertheless I am sure I hit most.
>> This patch uses the libiberty functions & macros about
>> directory-separator checks, absolute-path checks,
>> and the filename-comparision functions.
>
> Please don't inflict the DOS-stupidity on stuff like bsd-kvm.c and
> fbsd-nat.c.
>

hmm, I admit that it is pretty unlikely that *nix-nat parts are used
with DOS-style paths. Nevertheless on cross-compiling from windows to
*nix such paths can happen easily. Additionally it is IMHO also an
issue of consistance in source. To use on one place
abstraction-routines and on other places not, is something weak and
causes sooner or later troubles.
Nevertheless if I get a constructive review for this patch, and
reviewer asks me to remove some portions of it I am open-minded to do
so.

Regards,
Kai


  reply	other threads:[~2011-03-03 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTi=QoOiBg3XmMv+hRNe8DkT2YiVGZ=7NhaQwzCey@mail.gmail.com>
2011-03-03 12:02 ` Kai Tietz
2011-03-03 12:15   ` Mark Kettenis
2011-03-03 12:50     ` Kai Tietz [this message]
2011-03-03 13:13       ` Eli Zaretskii
2011-03-03 13:21         ` Kai Tietz
2011-03-03 13:43           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTin+0ozrOsXDQX7AgzqwokNCF3-P8443kLM2HrnT@mail.gmail.com \
    --to=ktietz70@googlemail.com \
    --cc=gdb@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox