From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1567 invoked by alias); 3 Mar 2011 12:50:48 -0000 Received: (qmail 1557 invoked by uid 22791); 3 Mar 2011 12:50:47 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 12:50:42 +0000 Received: by qwd7 with SMTP id 7so1012617qwd.0 for ; Thu, 03 Mar 2011 04:50:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.140.193 with SMTP id j1mr880236qcu.82.1299156640390; Thu, 03 Mar 2011 04:50:40 -0800 (PST) Received: by 10.229.89.197 with HTTP; Thu, 3 Mar 2011 04:50:40 -0800 (PST) In-Reply-To: <201103031214.p23CEj4Z010743@glazunov.sibelius.xs4all.nl> References: <201103031214.p23CEj4Z010743@glazunov.sibelius.xs4all.nl> Date: Thu, 03 Mar 2011 12:50:00 -0000 Message-ID: Subject: Re: [patch gdb]: Fix some DOS-path related issues in gdb From: Kai Tietz To: Mark Kettenis Cc: gdb@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00032.txt.bz2 2011/3/3 Mark Kettenis : >> Date: Thu, 3 Mar 2011 13:02:11 +0100 >> From: Kai Tietz >> >> Hello, >> >> This patch fixes some issues related to DOS file-system filenames and >> paths. I am not sure, if I >> hit all places, nevertheless I am sure I hit most. >> This patch uses the libiberty functions & macros about >> directory-separator checks, absolute-path checks, >> and the filename-comparision functions. > > Please don't inflict the DOS-stupidity on stuff like bsd-kvm.c and > fbsd-nat.c. > hmm, I admit that it is pretty unlikely that *nix-nat parts are used with DOS-style paths. Nevertheless on cross-compiling from windows to *nix such paths can happen easily. Additionally it is IMHO also an issue of consistance in source. To use on one place abstraction-routines and on other places not, is something weak and causes sooner or later troubles. Nevertheless if I get a constructive review for this patch, and reviewer asks me to remove some portions of it I am open-minded to do so. Regards, Kai