RE: MT_CFLAGS

RE: MT_CFLAGS

[Aleksandar Ristovski]

> -----Original Message-----
> From: Daniel Jacobowitz
> 
> On Thu, Jan 24, 2008 at 10:07:47AM -0500, Aleksandar Ristovski wrote:
> > Hello,
> >
> > I see that MT_CFLAGS is gone from Makefile.in.
> >
> > What is the alternative to getting the same result? I need to add a
> target
> > specific #define to CC, e.g. -DMY_DEFINE. What is the correct approach?
> 
> It was removed because we try not to add target-specific defines any
> more.  What do you need it for?
> 
> Normally proper use of gdbarch and target inheritance is enough.

I want to implement some fix-ups (workarounds) that are really specific to
us and have to be made in gdb files (not ours). The workarounds are not
candidates for mainstream, so I am wrapping them in our #ifdef-s... No big
deal really, I just thought there was a 'correct' way to do it. 

But maybe you have some other suggestion?

Thanks,

Aleksandar

Re: MT_CFLAGS

[Daniel Jacobowitz]

On Thu, Jan 24, 2008 at 10:20:30AM -0500, Aleksandar Ristovski wrote:
> I want to implement some fix-ups (workarounds) that are really specific to
> us and have to be made in gdb files (not ours). The workarounds are not
> candidates for mainstream, so I am wrapping them in our #ifdef-s... No big
> deal really, I just thought there was a 'correct' way to do it. 
> 
> But maybe you have some other suggestion?

If it's for local changes, there's plenty of ways to do it.  For
instance, specify them in CFLAGS when running configure, or add a
local line to the Makefile.in.  Or have the main configure script
define something based on $target if you want to be able to test
without them easily.

-- 
Daniel Jacobowitz
CodeSourcery

MT_CFLAGS

[Aleksandar Ristovski]

Hello,

I see that MT_CFLAGS is gone from Makefile.in. 

What is the alternative to getting the same result? I need to add a target
specific #define to CC, e.g. -DMY_DEFINE. What is the correct approach?

Thanks,

---
Aleksandar Ristovski
QNX Software Systems

Re: MT_CFLAGS

[Daniel Jacobowitz]

On Thu, Jan 24, 2008 at 10:07:47AM -0500, Aleksandar Ristovski wrote:
> Hello,
> 
> I see that MT_CFLAGS is gone from Makefile.in. 
> 
> What is the alternative to getting the same result? I need to add a target
> specific #define to CC, e.g. -DMY_DEFINE. What is the correct approach?

It was removed because we try not to add target-specific defines any
more.  What do you need it for?

Normally proper use of gdbarch and target inheritance is enough.

-- 
Daniel Jacobowitz
CodeSourcery

Re: MT_CFLAGS

[Mark Kettenis]

> From: Aleksandar Ristovski <ARistovski@qnx.com>
> Date: Thu, 24 Jan 2008 10:07:47 -0500
> 
> Hello,
> 
> I see that MT_CFLAGS is gone from Makefile.in. 
> 
> What is the alternative to getting the same result? I need to add a target
> specific #define to CC, e.g. -DMY_DEFINE. What is the correct approach?

If this is needed for building a native debugger, the correct approach
is to add an autoconf "check" that results in the right symbol being
defined in config.h.

If this is needed for building target-specific code, you're doing
something wrong.  The code for that should not depend on any
predefined symbols.