Re[2]: 4.17.86 on AIX 4.2.0.0 using IBM xlc

Re[2]: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[rodneybrown]

--- target.h.orig   Wed Jan 20 04:02:55 1999
+++ target.h    Wed Mar 24 14:04:00 1999
@@ -54,7 +54,7 @@
 enum thread_control_capabilities {
    tc_none = 0,        /* Default: can't control thread execution. */
    tc_schedlock = 1,   /* Can lock the thread scheduler. */
-   tc_switch = 2,      /* Can switch the running thread on demand. */
+   tc_switch = 2       /* Can switch the running thread on demand. */
 };
 
 /* Stuff for target_wait.  */
--- breakpoint.h.orig   Wed Jan 27 10:15:14 1999
+++ breakpoint.h    Wed Mar 24 14:04:47 1999
@@ -111,7 +111,7 @@
   /* These are catchpoints to implement "catch catch" and "catch throw"
      commands for C++ exception handling. */
   bp_catch_catch,
-  bp_catch_throw,
+  bp_catch_throw
 
  
 };
--- breakpoint.c.orig   Mon Mar  1 15:51:53 1999
+++ breakpoint.c    Wed Mar 24 14:09:25 1999
@@ -139,7 +139,7 @@
 
 typedef enum {
   mark_inserted,
-  mark_uninserted,
+  mark_uninserted
 } insertion_state_t;
 
 static int


xlc -c -g \
    -I. -I/net/reckless/devel/tmp/gdb-4.17.86/gdb \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/config -DHAVE_CONFIG_H \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/../include/opcode \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/../readline/.. -I../bfd \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/../bfd \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/../include \
    -I../intl -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/../intl \
    -I/net/reckless/devel/tmp/gdb-4.17.86/gdb/tui \
    /net/reckless/devel/tmp/gdb-4.17.86/gdb/rs6000-tdep.c
"/net/reckless/devel/tmp/gdb-4.17.86/gdb/rs6000-tdep.c", line 206.1: \
   1506-343 (S) Redeclaration of rs6000_software_single_step differs from \
   previous declaration on line 551 of \
   "/net/reckless/devel/tmp/gdb-4.17.86/gdb/config/rs6000/tm-rs6000.h".
"/net/reckless/devel/tmp/gdb-4.17.86/gdb/rs6000-tdep.c", line 206.1: \
   1506-381 (I) The type "unsigned int" of parameter 1 \
   in the prototype declaration is not compatible with the corresponding \
   parameter type "enum target_signal" in the nonprototype declaration.
make[1]: *** [rs6000-tdep.o] Error 1

This is problematic - correcting the declaration in tm-rs6000.h to
an enum target_signal requires target.h to be declared before defs.h in
rs6000-tdep.c



____________________Reply Separator____________________
Subject:    Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc 
Author: Stan Shebs <shebs@cygnus.com> 
Date:       23/03/99 18:54


   Date: Wed, 24 Mar 1999 10:05:07 +1100
   From: Andrew Cagney <ac131313@cygnus.com>

   Assuming that you're GPL assigned, would you be able to investigate the
   compile problems using the AIX compiler?

I assumed those two trailers were the only mistakes and already
committed the fixes.  Any other such mistakes would likely have been
fixed long ago, because of previous xlc or other compiler runs - these
two enums were recently introduced/modified.

                                                        Stan

Re[2]: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[rodneybrown]

For what it is worth the xlc lslpp information is

Fileset  Level  State Description
xlC.C    3.1.4.0  C   C for AIX Compiler


I note that my copy of the ANSI-C Standard
ISO/IEC 9899: 1990 Programming languages-C

doesn't have the trailing comma varient in section 6.5.2.2

A colleague notes that VMS Dec C gives a warning for the idiom.

____________________Reply Separator____________________
Subject:    Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc 
Author: Andrew Cagney <ac131313@cygnus.com> 
Date:       17/03/99 19:24

Andrew Cagney wrote:
> 
> rodneybrown@pmsc.com wrote:
> >
> > AIX 4.2.0.0 xlc gives an error for trailing commas in enum declarations
> > Specifically compiling gdb-4.17.86/gdb/blockframe.c it gives
> >
> > "gdb-4.17.86/gdb/target.h", line 57.22: 1506-046 (S) Syntax error.
> > "gdb-4.17.86/gdb/breakpoint.h", line 114.17: 1506-046 (S) Syntax error.
> 
> Thanks,

Hmm (is this a nightmare comming true?),

Looking at C manual:

6.5.2.2 Enumeration specifiers
Syntax
  enum-specifier:
    enum identifieropt { enumerator-list }
    enum identifieropt { enumerator-list , }
    enum identifier
  enumerator-list:
    enumerator
    enumerator-list , enumerator
  enumerator:
    enumeration-constant
    enumeration-constant = constant-expression

and the relevant line:

enum thread_control_capabilities {
        tc_none = 0,            /* Default: can't control thread
execution. */
        tc_schedlock = 1,       /* Can lock the thread scheduler. */
        tc_switch = 2,          /* Can switch the running thread on
demand. */
};

So, what to do about this one?

        Andrew