From: Jim Blandy <jimb@red-bean.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb@sourceware.org
Subject: Re: Packing "R" actions in a QTDP packet
Date: Tue, 22 Nov 2005 04:48:00 -0000 [thread overview]
Message-ID: <8f2776cb0511212048k751e1db5ida47625f0f7885df@mail.gmail.com> (raw)
In-Reply-To: <43822BC0.6010101@redhat.com>
On 11/21/05, Michael Snyder <msnyder@redhat.com> wrote:
> Jim Blandy wrote:
> > The code in stringify_collection_list will concatenate as many 'M' and
> > 'X' actions as it can in a packet, but it leaves 'R' actions in a
> > packet by themselves.
>
> Are you sure? That's not my recollection, though admittedly
> it's been 5 years or so... In my mental picture, the R bitmask
> goes somewhere in the QTDP message, just *before* the memranges.
Well, that's what the code does. It always does a savestring and
copies tmp_buf to the first entry in str_list, regardless of the size.
'count', used to track overall packet size in the 'M' and 'X' code,
doesn't even get used in the 'R' code.
> There is of course only one 'R' <thing> per tracepoint,
> because it's a bitmask...
Oops. That makes sense; I'd better document it.
prev parent reply other threads:[~2005-11-22 4:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-19 5:48 Jim Blandy
2005-11-21 20:19 ` Michael Snyder
2005-11-22 4:48 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0511212048k751e1db5ida47625f0f7885df@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb@sourceware.org \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox