From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29343 invoked by alias); 22 Nov 2005 04:48:42 -0000 Received: (qmail 29336 invoked by uid 22791); 22 Nov 2005 04:48:41 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.205) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Nov 2005 04:48:39 +0000 Received: by zproxy.gmail.com with SMTP id x3so1024833nzd for ; Mon, 21 Nov 2005 20:48:37 -0800 (PST) Received: by 10.36.220.6 with SMTP id s6mr3662004nzg; Mon, 21 Nov 2005 20:48:37 -0800 (PST) Received: by 10.37.2.35 with HTTP; Mon, 21 Nov 2005 20:48:37 -0800 (PST) Message-ID: <8f2776cb0511212048k751e1db5ida47625f0f7885df@mail.gmail.com> Date: Tue, 22 Nov 2005 04:48:00 -0000 From: Jim Blandy To: Michael Snyder Subject: Re: Packing "R" actions in a QTDP packet Cc: gdb@sourceware.org In-Reply-To: <43822BC0.6010101@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <8f2776cb0511182148u78181643o940ebd454d0e3901@mail.gmail.com> <43822BC0.6010101@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00459.txt.bz2 On 11/21/05, Michael Snyder wrote: > Jim Blandy wrote: > > The code in stringify_collection_list will concatenate as many 'M' and > > 'X' actions as it can in a packet, but it leaves 'R' actions in a > > packet by themselves. > > Are you sure? That's not my recollection, though admittedly > it's been 5 years or so... In my mental picture, the R bitmask > goes somewhere in the QTDP message, just *before* the memranges. Well, that's what the code does. It always does a savestring and copies tmp_buf to the first entry in str_list, regardless of the size. 'count', used to track overall packet size in the 'M' and 'X' code, doesn't even get used in the 'R' code. > There is of course only one 'R' per tracepoint, > because it's a bitmask... Oops. That makes sense; I'd better document it.