From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb@sourceware.org
Subject: Re: gdb.arch vs. gdb.base gcore test cases
Date: Fri, 03 May 2013 13:16:00 -0000 [thread overview]
Message-ID: <87wqrgfble.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <51839F41.2050101@redhat.com> (Pedro Alves's message of "Fri, 03 May 2013 12:28:01 +0100")
Pedro Alves <palves@redhat.com> writes:
> On 05/03/2013 12:15 PM, Andreas Arnez wrote:
>> The following two test cases are mostly identical, and their associated
>> C source files are exactly identical:
>>
>> gdb.arch/system-gcore.exp
>> gdb.base/gcore.exp
>>
>> Is there any specific reason for the two copies? Just curious...
>
> Well, what does git blame, and the initial submission of the
> corresponding patches say? The answer probably lies in what makes them
> "mostly identical" rather than "exactly identical" being arch
> specific. If the differences are really small, then we could merge
> them into gcore.exp, using istarget to guard the arch specific bits.
The common test case was introduced some time ago:
2002-01-08 Michael Snyder <msnyder@redhat.com>
* gdb.base/gcore.exp: New test for generate-core-file command.
* gdb.base/gcore.c: Testcase for above.
* gdb.threads/gcore-thread.exp: New test for gcore (threaded).
The x86-specific one is newer; it was introduced with this change:
2010-04-17 H.J. Lu <hongjiu.lu@intel.com>
PR corefiles/11511
* gdb.arch/system-gcore.exp: New.
* gdb.arch/gcore.c: Likewise.
The only functional difference seems to be that system-gcore.exp adds a
new comparison (before/after) for the output from "info reg system".
next prev parent reply other threads:[~2013-05-03 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 11:15 Andreas Arnez
2013-05-03 11:28 ` Pedro Alves
2013-05-03 13:16 ` Andreas Arnez [this message]
2013-05-03 14:00 ` Pedro Alves
2013-05-03 14:48 ` Andreas Arnez
2013-05-03 15:24 ` Pedro Alves
2013-05-03 15:06 ` Pedro Alves
2013-05-03 15:53 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqrgfble.fsf@br87z6lw.de.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox