From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28397 invoked by alias); 3 May 2013 13:16:05 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 28387 invoked by uid 89); 3 May 2013 13:16:05 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 03 May 2013 13:16:02 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 May 2013 14:10:28 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 3 May 2013 14:10:27 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2B8EF2190059 for ; Fri, 3 May 2013 14:18:33 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r43DFmaq57606172 for ; Fri, 3 May 2013 13:15:48 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r43DFwnJ010041 for ; Fri, 3 May 2013 07:15:58 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-143.boeblingen.de.ibm.com [9.152.212.143]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r43DFvDg010035; Fri, 3 May 2013 07:15:58 -0600 From: Andreas Arnez To: Pedro Alves Cc: gdb@sourceware.org Subject: Re: gdb.arch vs. gdb.base gcore test cases References: <8761z0gvr7.fsf@br87z6lw.de.ibm.com> <51839F41.2050101@redhat.com> Date: Fri, 03 May 2013 13:16:00 -0000 In-Reply-To: <51839F41.2050101@redhat.com> (Pedro Alves's message of "Fri, 03 May 2013 12:28:01 +0100") Message-ID: <87wqrgfble.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13050313-1948-0000-0000-0000050B0380 X-SW-Source: 2013-05/txt/msg00018.txt.bz2 Pedro Alves writes: > On 05/03/2013 12:15 PM, Andreas Arnez wrote: >> The following two test cases are mostly identical, and their associated >> C source files are exactly identical: >> >> gdb.arch/system-gcore.exp >> gdb.base/gcore.exp >> >> Is there any specific reason for the two copies? Just curious... > > Well, what does git blame, and the initial submission of the > corresponding patches say? The answer probably lies in what makes them > "mostly identical" rather than "exactly identical" being arch > specific. If the differences are really small, then we could merge > them into gcore.exp, using istarget to guard the arch specific bits. The common test case was introduced some time ago: 2002-01-08 Michael Snyder * gdb.base/gcore.exp: New test for generate-core-file command. * gdb.base/gcore.c: Testcase for above. * gdb.threads/gcore-thread.exp: New test for gcore (threaded). The x86-specific one is newer; it was introduced with this change: 2010-04-17 H.J. Lu PR corefiles/11511 * gdb.arch/system-gcore.exp: New. * gdb.arch/gcore.c: Likewise. The only functional difference seems to be that system-gcore.exp adds a new comparison (before/after) for the output from "info reg system".