Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches <gdb-patches@sourceware.org>,
	 "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: tclint, pre-commit and patch submissions
Date: Fri, 03 Oct 2025 13:47:07 -0600	[thread overview]
Message-ID: <87sefz6a4k.fsf@tromey.com> (raw)
In-Reply-To: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> (Tom de Vries's message of "Wed, 1 Oct 2025 13:55:10 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> If these patches are not tclint-clean, then after commit this command:
Tom> ...
Tom> $ pre-commit run tclint --all-files
Tom> ...
Tom> will start showing new tclint errors.

Tom> - we make the repo refuse commits that are not pre-commit clean

This one is tricky because we'd have to manage this stuff on the server
side.

Tom> - nothing changes, and submitters can use all/some/no pre-commit hooks
Tom>   for their own submissions

So far this hasn't been that big an issue IMO.  I think most of the
regular contributors use pre-commit.

Tom

      parent reply	other threads:[~2025-10-03 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01 11:55 Tom de Vries via Gdb
2025-10-01 12:30 ` Guinevere Larsen via Gdb
2025-10-01 17:17 ` Luis via Gdb
2025-10-03 19:47 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sefz6a4k.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox