From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GahHIDop4GjCEx4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 15:51:22 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CjF2zQ0M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 80BDF1E0B6; Fri, 03 Oct 2025 15:51:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1BC381E04C for ; Fri, 03 Oct 2025 15:51:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C183E385781B for ; Fri, 3 Oct 2025 19:51:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C183E385781B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CjF2zQ0M Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 78D5B3857BB9 for ; Fri, 3 Oct 2025 19:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78D5B3857BB9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 78D5B3857BB9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759520829; cv=none; b=HW7oBY9uzzpovWO9k9uyoqR+2sjKFL60+dr/gB6AiscxPMJjhFx41S+u5ed+hEg+bWpJ7aTOVpKA4EFG9RbBcwBdaAwzEQFx7iEqVun8ltj3fh4mC9zlvwDMvF6PTPfrEOaSo1xe/DswYchLrIPWMC7KXXrH50L/rbFzWi2e/gU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759520829; c=relaxed/simple; bh=0ZeY47I8soW5uMuq/D7ZozLIHjD3CZQMX9cqmPDeKqw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x1qd6dYxAL/R06TMp8DS6eMLxa65pBVXYIOaWYqdsy/W+LFoi1ykSBIawd83dxy2qLjMVjc7G9Q6pKteHJyarOIL4TIHjbQpxEOM7xn/52wNfjStEozp+4QjRhOGi61iUMwOzKcjY5TjURfWM+uab7QrIOwfVJpTiSsDwEXw4iU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78D5B3857BB9 Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id 4PA3vUKpWKXDJ4lkDvBiJZ; Fri, 03 Oct 2025 19:47:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4lkCvVssup0Hq4lkCvzHlv; Fri, 03 Oct 2025 19:47:08 +0000 X-Authority-Analysis: v=2.4 cv=H/nbw/Yi c=1 sm=1 tr=0 ts=68e0283c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=znregzvTH8yG571NoUsA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/n6WKIJmpYR2i52dY6atQadVFNs4/Z0mYtgvMzOiCcg=; b=CjF2zQ0MSTONAq9rg+y4Cyacyh u1r40M3drQHYxNGL6Rb1+SH5couyR+6K+bD1rYYuRBKCP1uEftb9se34XRXM2yDxlcIvzKNSWAWOu Psv2beIPz13cpo2uMTv+8/LB6; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:55374 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v4lkB-00000000qX3-3zoL; Fri, 03 Oct 2025 13:47:07 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches , "gdb@sourceware.org" Subject: Re: tclint, pre-commit and patch submissions In-Reply-To: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> (Tom de Vries's message of "Wed, 1 Oct 2025 13:55:10 +0200") References: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> X-Attribution: Tom Date: Fri, 03 Oct 2025 13:47:07 -0600 Message-ID: <87sefz6a4k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1v4lkB-00000000qX3-3zoL X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:55374 X-Source-Auth: tom+tromey.com X-Email-Count: 20 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfA9sj4BmSchMxB08JEHH+s4lxE4ILVUZGK6NHkxovS3vF45GqYNEyv7REOLhSFXNet0Lq9IhizLK+Iv/5PcYkkMSeBcgUTi8w44N1Rg3WCYOaBgsl2Ju 4/9B5imZWXpibklhx1ntvYpmh1iLIrPbCubCrCS9ANryhnKNpRtxaCAn5g1eJUn6RyhOQKeY2DMCIg== X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" >>>>> "Tom" == Tom de Vries writes: Tom> If these patches are not tclint-clean, then after commit this command: Tom> ... Tom> $ pre-commit run tclint --all-files Tom> ... Tom> will start showing new tclint errors. Tom> - we make the repo refuse commits that are not pre-commit clean This one is tricky because we'd have to manage this stuff on the server side. Tom> - nothing changes, and submitters can use all/some/no pre-commit hooks Tom> for their own submissions So far this hasn't been that big an issue IMO. I think most of the regular contributors use pre-commit. Tom