From: Tom Tromey <tromey@redhat.com>
To: Christian Groessler <chris@groessler.org>
Cc: gdb@sourceware.org
Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion
Date: Wed, 15 May 2013 14:55:00 -0000 [thread overview]
Message-ID: <87r4h82sza.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51936596.8010205@groessler.org> (Christian Groessler's message of "Wed, 15 May 2013 12:38:14 +0200")
>>>>> ">" == Christian Groessler <chris@groessler.org> writes:
>> I had some testsuite failures in gdb.dwarf2/dw2-dir-file-name.exp,
>> because /bin/sh on my system doesn't support brace expansion.
>> I'm using Debian, where /bin/sh is in fact dash. I tried /bin/sh on
>> Solaris (9), too, and it also doesn't support brace expansion.
>> This patch changes dw2-dir-file-name.exp to use bash instead of sh.
>> Ok to commit?
I think it would be better to rewrite this code to compute the list of
filenames in Tcl, then just send a simple command. It seems to me that
one can't rely on bash existing on the remote system.
Tom
next prev parent reply other threads:[~2013-05-15 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 10:38 Christian Groessler
2013-05-15 11:03 ` Luis Machado
2013-05-15 11:06 ` Christian Groessler
2013-05-15 14:55 ` Tom Tromey [this message]
2013-05-15 23:25 ` Sergio Durigan Junior
2013-05-17 7:45 ` Christian Groessler
2013-05-17 8:13 ` Joel Brobecker
2013-05-17 16:44 ` Tom Tromey
2013-05-17 22:57 ` Christian Groessler
2013-05-20 15:16 ` Tom Tromey
2013-05-21 7:27 ` Christian Groessler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4h82sza.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=chris@groessler.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox