From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32761 invoked by alias); 15 May 2013 14:55:59 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 32735 invoked by uid 89); 15 May 2013 14:55:54 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 14:55:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FEt8tT006216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 May 2013 10:55:08 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4FEt6sn003852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 15 May 2013 10:55:07 -0400 From: Tom Tromey To: Christian Groessler Cc: gdb@sourceware.org Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion References: <51936596.8010205@groessler.org> Date: Wed, 15 May 2013 14:55:00 -0000 In-Reply-To: <51936596.8010205@groessler.org> (Christian Groessler's message of "Wed, 15 May 2013 12:38:14 +0200") Message-ID: <87r4h82sza.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00067.txt.bz2 >>>>> ">" == Christian Groessler writes: >> I had some testsuite failures in gdb.dwarf2/dw2-dir-file-name.exp, >> because /bin/sh on my system doesn't support brace expansion. >> I'm using Debian, where /bin/sh is in fact dash. I tried /bin/sh on >> Solaris (9), too, and it also doesn't support brace expansion. >> This patch changes dw2-dir-file-name.exp to use bash instead of sh. >> Ok to commit? I think it would be better to rewrite this code to compute the list of filenames in Tcl, then just send a simple command. It seems to me that one can't rely on bash existing on the remote system. Tom