Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Samuel Bronson <naesten@gmail.com>
To: David Taylor <dtaylor@emc.com>
Cc: gdb@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: trace state variables -- remote protocol
Date: Sat, 26 Jul 2014 23:05:00 -0000	[thread overview]
Message-ID: <87oawbzpog.fsf@naesten.mooo.com> (raw)
In-Reply-To: <13630.1406235804@usendtaylorx2l> (David Taylor's message of	"Thu, 24 Jul 2014 17:03:24 -0400")

David Taylor <dtaylor@emc.com> writes:

> A minor documentation nit --
>
> I am looking into implementing trace state variables for our new GDB
> stub and noticed a discrepancy between the documentation and the code.
>
> In the documentation the QTDV message is described as having two fields
>
>     QTDV:n:value
>
> where 'n' is the trace state variable number and 'value' is its value.
>
> Looking at the code in GDB, it should be:
>
>     QTDV:n:value:builtin:name
>
> where
>
>     n is the trace state variable number
>     value is its value
>     builtin is a boolean -- is it builtin to the stub or not
>     name is a string

Maybe try writing a patch, submitting a bug report, or CCing Eli?
Otherwise, I'd worry that your suggestion might fall through the cracks.
(I've taken the liberty of CCing Eli.)

I would suggest CCing an area maintainer as well, but I'm not sure if
Daniel Jacobowitz is really still active.

(Note that it's not worth writing a patch yourself if you can't/don't
want to complete the annoying copyright assignment paperwork.)

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!


      reply	other threads:[~2014-07-26 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 21:03 David Taylor
2014-07-26 23:05 ` Samuel Bronson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oawbzpog.fsf@naesten.mooo.com \
    --to=naesten@gmail.com \
    --cc=dtaylor@emc.com \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox