From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9822 invoked by alias); 26 Jul 2014 23:05:45 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 9811 invoked by uid 89); 26 Jul 2014 23:05:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f52.google.com Received: from mail-qa0-f52.google.com (HELO mail-qa0-f52.google.com) (209.85.216.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 26 Jul 2014 23:05:42 +0000 Received: by mail-qa0-f52.google.com with SMTP id j15so6004639qaq.25 for ; Sat, 26 Jul 2014 16:05:40 -0700 (PDT) X-Received: by 10.140.32.134 with SMTP id h6mr41798119qgh.49.1406415940679; Sat, 26 Jul 2014 16:05:40 -0700 (PDT) Received: from hydrogen (naesten-pt.tunnel.tserv4.nyc4.ipv6.he.net. [2001:470:1f06:57::2]) by mx.google.com with ESMTPSA id x12sm20702599qaw.1.2014.07.26.16.05.38 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Jul 2014 16:05:39 -0700 (PDT) Received: from naesten by hydrogen with local (Exim 4.82) (envelope-from ) id 1XBB1z-0003xd-Rb; Sat, 26 Jul 2014 19:05:35 -0400 From: Samuel Bronson To: David Taylor Cc: gdb@sourceware.org, Eli Zaretskii Subject: Re: trace state variables -- remote protocol References: <13630.1406235804@usendtaylorx2l> Date: Sat, 26 Jul 2014 23:05:00 -0000 In-Reply-To: <13630.1406235804@usendtaylorx2l> (David Taylor's message of "Thu, 24 Jul 2014 17:03:24 -0400") Message-ID: <87oawbzpog.fsf@naesten.mooo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00027.txt.bz2 David Taylor writes: > A minor documentation nit -- > > I am looking into implementing trace state variables for our new GDB > stub and noticed a discrepancy between the documentation and the code. > > In the documentation the QTDV message is described as having two fields > > QTDV:n:value > > where 'n' is the trace state variable number and 'value' is its value. > > Looking at the code in GDB, it should be: > > QTDV:n:value:builtin:name > > where > > n is the trace state variable number > value is its value > builtin is a boolean -- is it builtin to the stub or not > name is a string Maybe try writing a patch, submitting a bug report, or CCing Eli? Otherwise, I'd worry that your suggestion might fall through the cracks. (I've taken the liberty of CCing Eli.) I would suggest CCing an area maintainer as well, but I'm not sure if Daniel Jacobowitz is really still active. (Note that it's not worth writing a patch yourself if you can't/don't want to complete the annoying copyright assignment paperwork.) -- Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!